Physics separator merge: Step5 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… call to edmf_run
…ent to edmf_run call in GFS_physics_driver to array
-fixed compilation issue that Chris found due to Grant's doxygen changes
…ed makefile to compile this file; other PBL schemes used tridin and tridi2 in moninedmf.f, so these subroutines don't really belong in EDMF module
…emes - created GFS_DCNV_generic.f90 with modules for pre and post - moved code from GFS_physics_driver.f90 to this file - call the new subroutines from GFS_physics_driver.f90 - edited makefile to compile new file - edits to sasasdeep_run table in mfdeepcnv.f - NOT TESTED YET (committing to test on Theia)
… the call to GFS_DCNV_generic_pre_run to try to fix B4B error introduced in commit e029001
|
I suggest to update the "end" statement to "end subroutine edmf_run" (needed by the CCPP build-time code parser), apart from that looks good to me. |
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Apr 7, 2020
* add fh00 post control file, add restart output at specified forecast hours, ugwd bug fixes * fv3atm NCAR#15:Add support for GEFS-Aerosols restart capability * remove comment prints * fix RunDuration in atmos fcst side * update post_gfs with new post changes * comment out print line * point fv3 dycore to the latest NOAA-EMC dev/emc branch
climbfuji
pushed a commit
to climbfuji/ccpp-physics
that referenced
this pull request
May 15, 2020
PBL tendencies were missing in two schemes; now fixed. Squashed commit of: * fix bugs found in pbl and ozone 3d diagnostic tendencies * remove debugging prints * implied shape arrays for five variables * more block labels * yet more bug fixes
dustinswales
pushed a commit
to dustinswales/ccpp-physics
that referenced
this pull request
Dec 16, 2022
Add the tc_pbl option used by HAFSv1 for GFS TKE EDMF PBL scheme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Grant Firl,
https://llpcarson@github.com/grantfirl/gmtb-gfsphysics
branch: EDMF_table
merged with master, bit-for-bit match with baseline.