-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Three changes and one bug fix in the NSST model in the coupled frame #537
Comments
@XuLi-NOAA thanks for reporting the bug and providing a solution for it! @SMoorthi-emc @junwang-noaa do you agree with the suggested bugfix? |
I knew the bug fix 2) is required to fix the first step large nsst impact, not sure about 1) and 3). |
I think this was done correctly in the IPD physics driver - bug happened during conversion to CCPP (I am only referring to the "tsfco" part of the bug) Other changes are up to Xu Li. I have corrected the "tsfco" error in my own branch of ccpp. |
Closed via #589. |
Three changes in this issue:
(1) Scheme-A to Scheme-A.1 in ccpp/physics
The cooling effect is removed from the formula to determine Tf
(2) Apply a safeguard to tref in sfc_nst_pre_run
(3) Reduce z_w_max from 30 m to 20 in ccpp/physics and FV3/io
A bug fix in ccpp
In order, the four following equations are executed in the code :
(1) tref(i) = max(tgice, tsfc_wat(i) - dtzm(i)
(2) tsfc_wat(i) = max(tgice, tref(i) + dtzm(i))
(3) tref(i) = max(tgice, tsfc_wat(i) - dtzm(i))
(4) tsfc_wat(i) = max(tgice, tref(i) + dtzm(i))
You can see tref is assigned twice (1) and (3), and tsfc_wat is assigned at (2) and (4), it explains what we saw in the figure exactly.
The solution is to introduce tsfco (the T1 from MOM6) into sfc_nst_pre_run in ccpp, and replace tsfc_wat in (1) and (3) to be tsfco.
The text was updated successfully, but these errors were encountered: