Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor capgen branch #410

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Refactor capgen branch #410

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
254c42b
Add new runtime info routine, ccpp_physics_suite_schemes
Oct 27, 2021
bbb668c
add optional var test, doctest cleanup, and python3 checks
Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/python.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
pip install flake8 pytest
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
- name: Test with pytest
if: github.repository == 'NCAR/ccpp-framework' # Only run on main repo
run: |
export PYTHONPATH=$(pwd)/scripts:$(pwd)/scripts/parse_tools
pytest
3 changes: 2 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
language: python

python:
- "2.7"
- "3.6"
- "3.7"
- "3.8"
- "3.9"

branches:
only:
Expand Down
12 changes: 6 additions & 6 deletions doc/HelloWorld/hello_scheme.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@
kind = len=512
intent = out
[ errflg ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename those as well.

Suggested change
[ errflg ]
[ errcode ]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do local variable names need to match standard names? This has never been a requirement as far as I recall.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was just a suggestion for consistency, of course they can be different (and given the comment on the long name errflg might be just as good).

standard_name = ccpp_error_flag
standard_name = ccpp_error_code
long_name = Error flag for error handling in CCPP
units = flag
units = 1
dimensions = ()
type = integer
intent = out
Expand All @@ -71,9 +71,9 @@
kind = len=512
intent = out
[ errflg ]
standard_name = ccpp_error_flag
standard_name = ccpp_error_code
long_name = Error flag for error handling in CCPP
units = flag
units = 1
dimensions = ()
type = integer
intent = out
Expand All @@ -89,9 +89,9 @@
kind = len=512
intent = out
[ errflg ]
standard_name = ccpp_error_flag
standard_name = ccpp_error_code
long_name = Error flag for error handling in CCPP
units = flag
units = 1
dimensions = ()
type = integer
intent = out
4 changes: 2 additions & 2 deletions doc/HelloWorld/hello_world_host.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
type = character
kind = len=512
[ errflg ]
standard_name = ccpp_error_flag
standard_name = ccpp_error_code
long_name = Error flag for error handling in CCPP
units = flag
units = 1
dimensions = ()
type = integer
12 changes: 6 additions & 6 deletions doc/HelloWorld/temp_adjust.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@
kind = len=512
intent = out
[ errflg ]
standard_name = ccpp_error_flag
standard_name = ccpp_error_code
long_name = Error flag for error handling in CCPP
units = flag
units = 1
dimensions = ()
type = integer
intent = out
Expand All @@ -58,9 +58,9 @@
kind = len=512
intent = out
[ errflg ]
standard_name = ccpp_error_flag
standard_name = ccpp_error_code
long_name = Error flag for error handling in CCPP
units = flag
units = 1
dimensions = ()
type = integer
intent = out
Expand All @@ -76,9 +76,9 @@
kind = len=512
intent = out
[ errflg ]
standard_name = ccpp_error_flag
standard_name = ccpp_error_code
long_name = Error flag for error handling in CCPP
units = flag
units = 1
dimensions = ()
type = integer
intent = out
Loading