Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dtc/develop into master 2020/04/14 #283

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Apr 14, 2020

  • speedup CCPP recompile
  • Python 3 compatibility
  • improvement to build system: pass CCPP kind and type definitions to host model
  • unit conversions for HWRT NOAH LSM
  • required cmake version now 3.0

Associated PRs:

NOAA-EMC/GFDL_atmos_cubed_sphere#17
#283
NCAR/ccpp-physics#436
NOAA-EMC/fv3atm#98
ufs-community/ufs-weather-model#102

For regression testing information, see ufs-community/ufs-weather-model#102

climbfuji and others added 30 commits December 10, 2019 13:32
…d metadata2html.py, improved error handling and diagnostic output for ccpp_prebuild.py
…from_dtc_20191210

ufs_public_release: updates from DTC (bugfixes, cleanup, optimization)
…authors

ufs_public_release: update version number and authors
…es_log_messages

ufs_public_release: bugfix for converting optional attribute from new metadata for ccpp_prebuild.py, correct log message for automated unit conversions
release/public-v4: remove reference to libxml2
…riable within CMakeLists.txt when building with the SCM
…n modules containing CCPP kind and type definitions to host model
RRTMGP in CCPP (updates to ccpp_prebuild.py)
…efile/cmakefile/sourcefile snippets if nothing has changed
…ange

dtc/develop: speed up static compilation
…conversion

dtc/develop: add unit conversions for Noah LSM, update CMakeLists.txt
… in scripts/mkcap.py for filenames without a path
@codecov-io
Copy link

Codecov Report

Merging #283 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   47.28%   47.28%           
=======================================
  Files          14       14           
  Lines        1343     1343           
=======================================
  Hits          635      635           
  Misses        708      708           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d678ce6...d678ce6. Read the comment docs.

Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.
Does this still work with python2?

from .parse_log import init_log, set_log_level
from .parse_log import set_log_to_stdout, set_log_to_null
from .parse_log import set_log_to_file
from .preprocess import PreprocStack
# End if
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder where that came from?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, all this works with Python 2.7, too.

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks familiar from previous reviews. Approved.

@climbfuji climbfuji merged commit 4b9cd89 into NCAR:master Apr 17, 2020
@climbfuji climbfuji deleted the update_master_from_dtc_develop_20200414 branch June 27, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants