-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dtc/develop into master 2020/04/14 #283
Merge dtc/develop into master 2020/04/14 #283
Conversation
…tic build is selected
…d metadata2html.py, improved error handling and diagnostic output for ccpp_prebuild.py
…from_dtc_20191210 ufs_public_release: updates from DTC (bugfixes, cleanup, optimization)
…authors ufs_public_release: update version number and authors
…ated unit conversions in ccpp_prebuild.py
…from new to old metadata
…es_log_messages ufs_public_release: bugfix for converting optional attribute from new metadata for ccpp_prebuild.py, correct log message for automated unit conversions
release/public-v4: remove reference to libxml2
…riable within CMakeLists.txt when building with the SCM
CMake Policy 0077
…n modules containing CCPP kind and type definitions to host model
RRTMGP in CCPP (updates to ccpp_prebuild.py)
… when no changes are made
…efile/cmakefile/sourcefile snippets if nothing has changed
…in scripts/mkstatic.py
…ange dtc/develop: speed up static compilation
…conversion dtc/develop: add unit conversions for Noah LSM, update CMakeLists.txt
… in scripts/mkcap.py for filenames without a path
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
=======================================
Coverage 47.28% 47.28%
=======================================
Files 14 14
Lines 1343 1343
=======================================
Hits 635 635
Misses 708 708 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
Does this still work with python2?
from .parse_log import init_log, set_log_level | ||
from .parse_log import set_log_to_stdout, set_log_to_null | ||
from .parse_log import set_log_to_file | ||
from .preprocess import PreprocStack | ||
# End if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder where that came from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, all this works with Python 2.7, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks familiar from previous reviews. Approved.
Associated PRs:
NOAA-EMC/GFDL_atmos_cubed_sphere#17
#283
NCAR/ccpp-physics#436
NOAA-EMC/fv3atm#98
ufs-community/ufs-weather-model#102
For regression testing information, see ufs-community/ufs-weather-model#102