Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main from feature/capgen following the refactoring and implementation of strict metadata units checking #416

Closed
climbfuji opened this issue Nov 10, 2021 · 0 comments · Fixed by #415 or ufs-community/ufs-weather-model#907
Closed

Update main from feature/capgen following the refactoring and implementation of strict metadata units checking #416

climbfuji opened this issue Nov 10, 2021 · 0 comments · Fixed by #415 or ufs-community/ufs-weather-model#907
Labels
capgen-unification Issues/PRs necessary for capgen/prebuild unification ccpp_prebuild bugs, requests, etc. that involve ccpp_prebuild enhancement

Comments

@climbfuji
Copy link
Collaborator

Description

With the metadata parser update in the refactoring update of the feature/capgen branch (#410), a stricter checking of units is enforced. This includes the replacement of "convenience units" such as log(Pa) with 1. Afterwards, feature/capgen was updated from main (#414).

Now feature/capgen needs to be merged back into main so that the strict unit checking will be enabled for NCAR ccpp-physics main, fv3atm and ccpp-scm.

Solution

Update main from feature/capgen and fix invalid units.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
capgen-unification Issues/PRs necessary for capgen/prebuild unification ccpp_prebuild bugs, requests, etc. that involve ccpp_prebuild enhancement
Projects
None yet
Milestone
No milestone
1 participant
@climbfuji