initialize boolean control vars in tidal mixing mod #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This was caught by Travis, which uses gfortran. It does not happen with intel.
…initialize_tidal_ctrl_vars
|
Okay, now Travis passes, but we still need to comment out things we shouldn't. Let's further investigate before synching with GFDL. |
gustavo-marques
approved these changes
Apr 19, 2018
|
@alperaltuntas Thanks for fixing that. I will add again the calls to deallocate arrays and, if everything works and passes the tests, I will send a PR to dev/master. |
mnlevy1981
referenced
this pull request
in mnlevy1981/MOM6
Apr 20, 2021
Merge in latest dev/gfdl updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue with Travis GNU compiler which doesn't initialize vars by default.