Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize management of empty attributes #38

Closed
tloubrieu-jpl opened this issue Nov 4, 2020 · 1 comment
Closed

Standardize management of empty attributes #38

tloubrieu-jpl opened this issue Nov 4, 2020 · 1 comment
Assignees
Labels

Comments

@tloubrieu-jpl
Copy link
Member

tloubrieu-jpl commented Nov 4, 2020

choose between null, nan or not having the attribute or other options

Acceptance criteria:
Check that specification is clear about the management of empty fields or attributes, see:

  1. https://github.com/NASA-PDS/pds-api/blob/master/docs/spec/pds-api-specification.md
  2. and online https://nasa-pds.github.io/pds-api/
@tloubrieu-jpl
Copy link
Member Author

Added sentence in specification:
Missing values: If a property is optional or has an empty or null value, consider dropping the property from the JSON, unless there's a strong semantic reason for its existence (taken from https://softwareengineering.stackexchange.com/questions/285010/null-vs-missing-key-in-rest-api-response
)

See https://docs.google.com/document/d/16d0MVh48bFLvWsa5-B_Hy-cby1rGWdnNojWOJpUcOvA/edit?usp=sharing

Demo implementation updated to comply with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants