-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pds api not able to search using URL parameters #130
Comments
@tloubrieu-jpl here is the corresponding ticket from I&T |
@gxtchen I was able to make that request work:
I think this is equivalent to the one which you tested but did not work. I think the reason why it did not work is the quote missing around the lid url value. Did you get this request from a documentation that we should update. |
@tloubrieu-jpl should we update the API to support without quotes? this seems a little too rigid and may cause some heartburn for users? |
@jordanpadams , @al-niessner spent a some time to make the query handle values without quote and then, @tdddblog made some change in August which led to not supporting the values without quotes. I would say we should wait bit before supporting values without quotes again, but the best might be to discuss that during a breakout session. |
@tloubrieu-jpl copy. So do all values needed to be enclosed in quotes or just strings? Either way, I think what I am getting at here is we should at least document when you need quotes. And then we can reevaluate later. |
@jordanpadams Perfect, I created a ticket for the documentation of the API query: #137 |
🐛 Describe the bug identified during I&T
When I search using the command:
curl -X GET --header 'Accept: application/json' 'https://pds-gamma.jpl.nasa.gov/api/products/urn%3Anasa%3Apds%3Ainsight_documents'
The Api returns the correct result. But when I try to use the ? search:
curl -X GET --header 'Accept: application/json' 'https://pds-gamma.jpl.nasa.gov/api/products?limit=100&q=lid%20eq%20urn%3Anasa%3Apds%3Ainsight_documents&only-summary=false'
API returns 404, no content.
🥼 Related Test Case(s)
NASA-PDS/registry-api#462
🖥 System Info
🦄 Related requirements
⚙️ Engineering Details
The text was updated successfully, but these errors were encountered: