Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worknet plugins/extensions #7

Merged
merged 11 commits into from
Jul 11, 2023
Merged

Worknet plugins/extensions #7

merged 11 commits into from
Jul 11, 2023

Conversation

ngdentdev
Copy link
Collaborator

No description provided.

@ngdentdev ngdentdev requested review from devhawk and JohndeVadoss July 6, 2023 18:07
Copy link
Contributor

@devhawk devhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few comments with suggested changes

…put to a file

- updated pluginHandler method to take TextWriter instead of IConsole so we don't have to depend on console
@ngdentdev ngdentdev marked this pull request as ready for review July 10, 2023 17:54
Copy link
Contributor

@devhawk devhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to merge once null conditional operator use + expanded ConfigFile overload comment are addressed

- use writer?.WriteLine pattern to avoid the null check in PluginHandler class
@@ -162,6 +162,8 @@ Console.WriteLine(JsonConvert.SerializeObject(payload));

### Extending NEO Worknet

Plugins/modules can be created to extend the functionality of Neo Worknet. [Neo Modules](https://github.com/neo-project/neo-modules/tree/master) contains a set of plugins that can be used with Neo. Many of these plugins can also be used with Neo Worknet. To use them, simply drop the dlls containing the plugins into the ~/.neo/plugins folder or /plugins folder in the worknet exe folder. Neo Worknet will automatically load and execute the plugins.
Neo Worknet's capabilities can be extended through the use of plugins or modules. The [Neo Modules](https://github.com/neo-project/neo-modules/tree/master) package offers a variety of plugins compatible with both Neo and Neo Worknet. To utilize these plugins, simply copy the DLL files containing the plugins into either the ~/.neo/plugins directory or the /plugins directory located within the worknet executable folder. Upon initiation, Neo Worknet will automatically load and activate these plugins.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also mention the need to override ConfigFile here in the readme?

@devhawk
Copy link
Contributor

devhawk commented Jul 11, 2023

:shipit:

@devhawk devhawk merged commit 5ccf046 into main Jul 11, 2023
@devhawk devhawk deleted the worknetPlugins branch July 11, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants