Create shortcut

[Sergei-Alekseev]

Describe the bug
Create shortcut button in activity section make nothing.

To Reproduce
Steps to reproduce the behaviour:

1. Go to 'activities tab.'
2. Click on 'create shortcut' on some activity.

Expected behavior
Shortcut is created.

Crash logs
Cant add logs because logd is removed. And no crashes at all.

Device info

• Device: Fly FS526 Power Plus 2
• OS Version: Android 7
• App Manager Version: v2.6.4
• Mode: root, Magisk.

Additional context
Default launcher is removed. Current default launcher is Holo Launcher.

[MuntashirAkon]

AM tries to create shortcuts using all the methods provided by the AOSP. If they don't work, there isn't much I can do about it without logs. Sorry!

[MuntashirAkon]

Closed due to lack of response. Feel free to open it again if you're still facing the issue.

[chsbuffer]

AppManager/app/src/main/java/io/github/muntashirakon/AppManager/details/EditShortcutDialogFragment.java

Line 105 in 47931ef

CharSequence newShortcutName = mShortcutNameField.getText();

this getText() returns a SpannableString (like String, it also implements CharSequence)

but Pixel Launcher only allows String as shortcut name. (tho I didn't find a docment says it MUST be String)

MIUI Launcher also use getStringExtra("android.intent.extra.shortcut.NAME"), but it forgets to null check lol.

com.miui.home crash log

09-15 21:48:10.837 18458 18458 E AndroidRuntime: FATAL EXCEPTION: main
09-15 21:48:10.837 18458 18458 E AndroidRuntime: Process: com.miui.home, PID: 18458
09-15 21:48:10.837 18458 18458 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke interface method 'java.lang.String java.lang.CharSequence.toString()' on a null object reference
09-15 21:48:10.837 18458 18458 E AndroidRuntime:        at com.miui.home.launcher.ShortcutInfo.makeUniquelyShortcutKey(ShortcutInfo.java:609)
09-15 21:48:10.837 18458 18458 E AndroidRuntime:        at com.miui.home.launcher.LauncherModel.isDupShortcut(LauncherModel.java:2623)
09-15 21:48:10.837 18458 18458 E AndroidRuntime:        at com.miui.home.launcher.InstallShortcutReceiver$1.run(InstallShortcutReceiver.java:214)
09-15 21:48:10.837 18458 18458 E AndroidRuntime:        at android.os.Handler.handleCallback(Handler.java:938)
09-15 21:48:10.837 18458 18458 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:99)
09-15 21:48:10.837 18458 18458 E AndroidRuntime:        at android.os.Looper.loopOnce(Looper.java:210)
09-15 21:48:10.837 18458 18458 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:299)
09-15 21:48:10.837 18458 18458 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:8105)
09-15 21:48:10.837 18458 18458 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
09-15 21:48:10.837 18458 18458 E AndroidRuntime:        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:556)
09-15 21:48:10.837 18458 18458 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1045)

I would blame AndroidX for not handling it well.

Workaround (untested)

 CharSequence newShortcutName = mShortcutNameField.getText().toString();

[MuntashirAkon]

Thanks for finding that out. The fix will be available in the next release.

[MuntashirAkon]

I would blame AndroidX for not handling it well.

This indeed looks as if the field is meant for String only. Maybe you should open an issue in the Google issue tracker, too.

[MuntashirAkon]

Should be fixed in c47333f. I don't know if it is fixed for certain because I have no way to test this.