Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PR for BIP44 support work for Bitcoinj #441

Open
gary-rowe opened this issue Mar 2, 2015 · 4 comments
Open

Create PR for BIP44 support work for Bitcoinj #441

gary-rowe opened this issue Mar 2, 2015 · 4 comments
Milestone

Comments

@gary-rowe
Copy link
Contributor

The BIP44 support work is currently held in our Bitcoinj-Alice fork. It would be better if this work could be generalised and pushed upstream for other projects to benefit from.

This is a complex change and may require a lot of support work before a PR would be accepted upstream. For this reason it has to occur after the first release of the project.

@gary-rowe gary-rowe added this to the Release 0.2 Webcam milestone Mar 2, 2015
@devrandom
Copy link

I have a general implementation that allows a DKC to have an arbitrary account derivation path. Should I'll compare my implementation to yours and see which one makes more sense to create a PR out of?

(Cc @mikehearn)

@jim618
Copy link
Contributor

jim618 commented Mar 15, 2015

It sounds similar.
I found the serialisiing and deserialising of the wallets to be the least general part of the bitcoinj-alice code - not really good enough for a general purpose library.

@devrandom
Copy link

Yes, I had the same experience, due to the use of static functions. Ended up with some factory classes to generalize.

@devrandom
Copy link

Created bitcoinj/bitcoinj#339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants