Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Use WebChannels for communicating with the FxA #2130

Closed
keianhzo opened this issue Nov 4, 2019 · 3 comments
Closed

Use WebChannels for communicating with the FxA #2130

keianhzo opened this issue Nov 4, 2019 · 3 comments
Assignees
Labels
ARCHIVED CLOSED at time of archiving blocked size: 1
Milestone

Comments

@keianhzo
Copy link
Contributor

keianhzo commented Nov 4, 2019

Is your feature request related to a problem? Please describe.
Pre @grigoryk comment on: #1973 (comment)

Since we're using Gecko, we should use WebChannels for communicating with the FxA web content, instead of intercepting URL loads.

This is basically all you need: https://github.com/mozilla-mobile/fenix/pull/4931/files#diff-bf0b57d467da0e3d5ef96c23fc828376R383

I'm assuming there shouldn't be a problem with installing a WebExtension in FxR, right?

Once you integrate the webchannels support, for free you get handling of "Choose what to sync" selection during FxA sign-up, which your current interceptor-based integration doesn't support. Also with a tiny bit of extra work, ability to add "Manage Account" button to your FxA settings page.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@keianhzo keianhzo added this to the #6 features milestone Nov 4, 2019
@keianhzo keianhzo self-assigned this Nov 4, 2019
@keianhzo keianhzo modified the milestones: #6 features, #7 polish Nov 4, 2019
@keianhzo
Copy link
Contributor Author

Waiting for info about where to get the webchannels extension.

@jvonitter jvonitter modified the milestones: #7 polish, #8 features Nov 22, 2019
@jvonitter
Copy link
Contributor

@keianhzo is there an ETA for when we'll hear about this? or should i shift it to the backlog until we get news?

@jvonitter jvonitter modified the milestones: #8 features, Backlog Jan 13, 2020
@keianhzo
Copy link
Contributor Author

@jvonitter We have decided to talk to the AC team in the All-Hands and expose them the need of making AC more aware of FxR in general. This is part of that conversation. We should provide time estimation and a proposal to evaluate and maybe contribute.

@cknowles-admin cknowles-admin added the ARCHIVED CLOSED at time of archiving label Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ARCHIVED CLOSED at time of archiving blocked size: 1
Projects
None yet
Development

No branches or pull requests

3 participants