Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Browser window and nav bar should appear together when making a new window. #1641

Closed
bluemarvin opened this issue Aug 22, 2019 · 2 comments · Fixed by #1697
Closed

Browser window and nav bar should appear together when making a new window. #1641

bluemarvin opened this issue Aug 22, 2019 · 2 comments · Fixed by #1697
Assignees
Labels
blocked bug This issue is a software or functional defect enhancement This issue is a new feature or request UX Issue relates to UX
Milestone

Comments

@bluemarvin
Copy link
Contributor

Configuration

Firefox Reality version: all
Firefox Reality build ID: all

Hardware: all

Steps to Reproduce

  1. Create a new window.

Current Behavior

The nav bar is shown but the window is not show until gecko renders to the surface texture.

Expected Behavior

A window should be shown even if it is blank.

Possible Solution

Draw a temporary quad placeholder for the window. It could be white for regular windows and purple for private browsing. Not drawing the window immediately on window creation makes FxR seem unresponsive and slow. We would need to have different implementations for layers and non-layer window rendering.

@bluemarvin bluemarvin added the enhancement This issue is a new feature or request label Aug 22, 2019
@bluemarvin bluemarvin added this to the v1.x milestone Aug 22, 2019
@jvonitter jvonitter changed the title Draw blank quad for a window while waiting for Gecko to render for a new window Browser window and nav bar should appear together when making a new window. Aug 22, 2019
@jvonitter jvonitter modified the milestones: v1.x, v1.4 Aug 22, 2019
@jvonitter jvonitter added bug This issue is a software or functional defect UX Issue relates to UX labels Aug 22, 2019
@MortimerGoro MortimerGoro self-assigned this Aug 22, 2019
@bluemarvin bluemarvin modified the milestones: v1.4, v1.5 Aug 29, 2019
@bluemarvin
Copy link
Contributor Author

These GeckoView issues need to be resolved to unblock this feature.
https://bugzilla.mozilla.org/show_bug.cgi?id=1578947
https://bugzilla.mozilla.org/show_bug.cgi?id=1578949

@jvonitter jvonitter added the QA Attention QA label Sep 20, 2019
@Softvision-GeluHaiduc
Copy link

I have verified that this issue is no longer reproducible with the latest Firefox Reality 1.5-32622233 (cfdab61) installed on the Oculus Go, Quest, HTC Vive Focus, Focus Plus and Lenovo Mirage Solo headsets.
Now, the browser window and nav bar appear together when a new window is opened, and a placeholder is displayed.
However, it seems that the color of the placeholder background is easily confused with the background of the max window limit popup. I logged a new issue regarding this behavior: #1862

@Softvision-GeluHaiduc Softvision-GeluHaiduc removed the QA Attention QA label Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked bug This issue is a software or functional defect enhancement This issue is a new feature or request UX Issue relates to UX
Projects
None yet
5 participants