Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up dropdown code #3759

Closed
youriwims opened this issue Oct 9, 2019 · 3 comments
Closed

Clean up dropdown code #3759

youriwims opened this issue Oct 9, 2019 · 3 comments
Labels
code cleanup engineering
Milestone
Icebox

Comments

@youriwims
Copy link
Contributor

youriwims commented Oct 9, 2019 •
edited
Loading

See #3691 #3628

[Follow-up clean-up ticket]: Look through updated files in these tickets' associated PRs to see if anything can be refactored and/or cleaned up.

Look into:

  • localizing #nav-newsletter-form-wrapper height value.
@youriwims youriwims mentioned this issue Oct 9, 2019
Merged
@youriwims
Copy link
Contributor Author

image

Error state spacing fixed in #3771 cc @kristinashu

@youriwims
Copy link
Contributor Author

Dropdown styles component-ized in #3771 and added to buyer's guide.

@TheoChevalier TheoChevalier mentioned this issue Oct 14, 2019
Closed
@gideonthomas gideonthomas added this to the Icebox milestone Nov 8, 2019
@cadecairos
Copy link

Closing this issue due to its age, if this is work that we still want to do, please refile this with up to date information so that it can be put in the correct milestone with up to date estimates.

@data-sync-user data-sync-user mentioned this issue Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code cleanup engineering
Projects
None yet
Milestone
Icebox
Development

No branches or pull requests
3 participants
@cadecairos @gideonthomas @youriwims