Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external link icon to nav button #3219

Closed
kristinashu opened this issue May 23, 2019 · 4 comments
Closed

Add external link icon to nav button #3219

kristinashu opened this issue May 23, 2019 · 4 comments
Labels

Comments

@kristinashu
Copy link

Add external link icon to nav button when the link is external.

@sabrinang can you please provide an svg of the icon?

Comp:
image

Prod:
image

@kristinashu kristinashu added the qa label May 23, 2019
@sabrinang
Copy link

Let's go with external icon with full square (looks better at small size too) and use at 16px inline with buttons.

Comparison with alternative icon:
Screen Shot 2019-05-23 at 1 50 07 PM

Exported Black/White svgs here:
https://drive.google.com/open?id=1sc9am1e190ICxW2MbcWgvVoB95gtrXDy

@kristinashu
Copy link
Author

"Submit Proposal" is now an internal page so we won't need the icon. But let's keep this open in case we need it for a different CTA. @sabrinang can you think of a future CTA button that would need it?

@kristinashu kristinashu added blocked and removed qa labels May 24, 2019
@sabrinang
Copy link

I'm assuming tickets will stay internal and schedule, speakers pages have yet to be created but hoping they are internal as well! Not quite sure where the schedule will live

@kristinashu
Copy link
Author

Ok awesome, let's close this then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants