Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up line height for .body-large to 1.5 #3081

Closed
mmmavis opened this issue Apr 30, 2019 · 2 comments · Fixed by #3082
Closed

Bump up line height for .body-large to 1.5 #3081

mmmavis opened this issue Apr 30, 2019 · 2 comments · Fixed by #3082
Assignees
@mmmavis
Labels
design frontend

Comments

@mmmavis
Copy link
Collaborator

mmmavis commented Apr 30, 2019

We've decided to bump up line height for .body-large to 1.5.

/cc @sabrinang @beccaklam
@mmmavis mmmavis self-assigned this Apr 30, 2019
@mmmavis mmmavis mentioned this issue Apr 30, 2019
Merged
@sabrinang
Copy link

sabrinang commented May 1, 2019 •
edited
Loading

I updated https://foundation.mozilla.org/en/docs/brand/design/Typography/ .body-large and it's dark theme version in the documentation (20px/30px) to match

@beccaklam Can you update the sketch style guide text style to reflect this line height update?

@beccaklam
Copy link

Yup I did that, also updated the mobile .body-large from 18/24 to 18/27 @sabrinang

@data-sync-user data-sync-user mentioned this issue Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmmavis mmmavis

Labels
design frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed line height for .body-large to 1.5 MozillaFoundation/foundation.mozilla.org
3 participants
@sabrinang @mmmavis @beccaklam