Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign-up component bug - email validation error for invalid email should be inline #3051

Closed
mmmavis opened this issue Apr 23, 2019 · 4 comments · Fixed by #3430
Closed

Sign-up component bug - email validation error for invalid email should be inline #3051

mmmavis opened this issue Apr 23, 2019 · 4 comments · Fixed by #3430
Assignees
@mmmavis
Labels
bug engineering frontend

Comments

@mmmavis
Copy link
Collaborator

mmmavis commented Apr 23, 2019

Describe the bug
According to design - email validation error should be inline and not appear in a browser default error bubble.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://foundation.mozilla.org
  2. Scroll down to the footer section
  3. Type something random in email field
  4. See error

Expected behavior
Error message for invalid email should be inline.

Screenshots
sign up error bubble
@mmmavis
Copy link
Collaborator Author

mmmavis commented Apr 23, 2019

Related to #3005 (this bug can be fixed if #3005 gets tackled first)

@mmmavis mmmavis mentioned this issue Apr 23, 2019
Merged
@alanmoo alanmoo self-assigned this Jun 5, 2019
@alanmoo
Copy link
Contributor

alanmoo commented Jun 25, 2019

Would adding novalidate to the <form> element be sufficient here? Or is this a broader issue?

@mmmavis
Copy link
Collaborator Author

mmmavis commented Jul 17, 2019

Yea I think novalidate + some small code changes will fix this issue. @alanmoo if you haven't started working on this I'm gonna re-assign this ticket to myself since I just fixed the same issue on Pulse.

@alanmoo
Copy link
Contributor

alanmoo commented Jul 17, 2019

Go for it

@mmmavis mmmavis assigned mmmavis and unassigned alanmoo Jul 17, 2019
@mmmavis mmmavis mentioned this issue Jul 17, 2019
Merged
This was referenced Jun 3, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmmavis mmmavis

Labels
bug engineering frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sign up component's browser error bubble issue MozillaFoundation/foundation.mozilla.org
2 participants
@alanmoo @mmmavis