-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Alignment on Primary & Bannered Campaign Pages #3022
Comments
@beccaklam (update: nvm I think I confused myself with mobile nav vs zen nav) https://getbootstrap.com/docs/4.0/layout/overview/#responsive-breakpoints
|
Mavis your too fast lol! Just a couple notes that I think Rebecca was going to update the ticket with tomorrow:
|
I have WIP review app for testing here: PR #3025 If it's easier - we can stay after stand tomorrow for quick discussion. Otherwise updating this ticket will work too. |
@mmmavis Checked out your PR and it looks good. Let's stay on after stand to chat through if we need the other adjustments I suggested in the Requirements Checklist. cc: @kristinashu |
@mmmavis The intro text looks good, once the spacing is implemented between the intro text and the subnav (only on pages with subnav for now?) let me know and I can check it before approving the PR. I looked at pages without the subnav and it looks like they may benefit form having a visual break (i.e. a line) in between the intro text and body copy but we can file a separate implementation ticket for that. |
Update the alignment on the Bannered Campaign Pages so the user's eye doesn't have to bounce around so much.
mobilemedium mockups are included below (mobile should remain the same):Requirements Checklist:
Desktop
Medium
The text was updated successfully, but these errors were encountered: