Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Alignment on Primary & Bannered Campaign Pages #3022

Closed
6 of 7 tasks
beccaklam opened this issue Apr 16, 2019 · 6 comments · Fixed by #3025
Closed
6 of 7 tasks

Update Alignment on Primary & Bannered Campaign Pages #3022

beccaklam opened this issue Apr 16, 2019 · 6 comments · Fixed by #3025
Assignees
Labels

Comments

@beccaklam
Copy link

beccaklam commented Apr 16, 2019

Update the alignment on the Bannered Campaign Pages so the user's eye doesn't have to bounce around so much.

  • Design has been finalized
  • Link to original design ticket: Primary page banner spacing and alignment #2935
  • Link to Redpen: https://redpen.io/p/eu7e43fa328483dfb7
  • Design changes been merged into the master Sketch file (you can find this file in the Foundation Site file on the Campaigns page, designs are titled 'New Bannered Campaign Alignment')
  • Desktop and mobile medium mockups are included below (mobile should remain the same):

Requirements Checklist:

  • "Cut out" should take up 8 columns
  • Increase spacing between explainer text and subnav to 48px

Screen Shot 2019-04-17 at 11 11 52 AM

Desktop

meet-our-fellows copy@2x

Medium

Med  Full Width

@mmmavis mmmavis self-assigned this Apr 16, 2019
@mmmavis mmmavis changed the title Update Alignment on Bannered Campaign Pages Update Alignment on Primary & Bannered Campaign Pages Apr 16, 2019
@mmmavis
Copy link
Collaborator

mmmavis commented Apr 16, 2019

@beccaklam question regarding the Medium mockup you included - did you mean for devices that are in between 576px to 767px (Bootstrap's "small devices")? Our nav doesn't "collapse" for tablets (Bootstrap's "medium" devices) but in your mockup I see hamburger icon / collapsed nav.

(update: nvm I think I confused myself with mobile nav vs zen nav)

https://getbootstrap.com/docs/4.0/layout/overview/#responsive-breakpoints

// Extra small devices (portrait phones, less than 576px)
@media (max-width: 575.98px) { ... }

// Small devices (landscape phones, 576px and up)
@media (min-width: 576px) and (max-width: 767.98px) { ... }

// Medium devices (tablets, 768px and up)
@media (min-width: 768px) and (max-width: 991.98px) { ... }

// Large devices (desktops, 992px and up)
@media (min-width: 992px) and (max-width: 1199.98px) { ... }

// Extra large devices (large desktops, 1200px and up)
@media (min-width: 1200px) { ... }

@kristinashu
Copy link

Mavis your too fast lol!

Just a couple notes that I think Rebecca was going to update the ticket with tomorrow:

  • this should be for all pages that have that banner so both Bannered campaign pages & Primary pages like /about
  • I think we also want to add some space below the intro text and above the subnav but Rebecca will add specs for that tomorrow

@mmmavis
Copy link
Collaborator

mmmavis commented Apr 16, 2019

I have WIP review app for testing here: PR #3025 If it's easier - we can stay after stand tomorrow for quick discussion. Otherwise updating this ticket will work too.

@beccaklam
Copy link
Author

Here's a mockup of About (though, now that I think about it, Fellowships uses the Primary Page template too?). Also I updated the Requirements Checklist at the top ^
Extra Large (≥1200px)

@beccaklam
Copy link
Author

@mmmavis Checked out your PR and it looks good. Let's stay on after stand to chat through if we need the other adjustments I suggested in the Requirements Checklist. cc: @kristinashu

@beccaklam
Copy link
Author

@mmmavis The intro text looks good, once the spacing is implemented between the intro text and the subnav (only on pages with subnav for now?) let me know and I can check it before approving the PR. I looked at pages without the subnav and it looks like they may benefit form having a visual break (i.e. a line) in between the intro text and body copy but we can file a separate implementation ticket for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants