Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AlignedImageBlock from customblocks #3008

Closed
youriwims opened this issue Apr 11, 2019 · 4 comments · Fixed by #4222
Closed

Remove AlignedImageBlock from customblocks #3008

youriwims opened this issue Apr 11, 2019 · 4 comments · Fixed by #4222

Comments

@youriwims
Copy link
Contributor

youriwims commented Apr 11, 2019

Describe the bug
The class AlignedImageBlock is still in customblocks.py but doesn't appear to be in use. This is a follow up to #2999.

To Reproduce
Steps to reproduce the behavior:

  1. Go to /network-api/networkapi/wagtailpages/customblocks.py
  2. Line 73 still has unused AlignedImageBlock class.
@youriwims youriwims self-assigned this Apr 11, 2019
@youriwims youriwims changed the title Figure out if AlignedImageBlock is still in use Remove AlignedImageBlock from customblocks Apr 16, 2019
@Sharma-palak
Copy link

@youriwims ,Is this issue still open? can i take this issue ??

@Pomax
Copy link
Contributor

Pomax commented Aug 11, 2019

@kristinashu can you confirm our content no longer requires this block to exist?

@kristinashu
Copy link

I checked with Youri and she has confirmed that we should remove this block.

I also checked our inventory and it isn't showing up so guess it isn't in use anywhere:
image

@Pomax Pomax added this to the Icebox milestone Sep 23, 2019
@mmmavis mmmavis self-assigned this Feb 14, 2020
@mmmavis mmmavis modified the milestones: Icebox, Feb 24 Feb 14, 2020
@mmmavis
Copy link
Collaborator

mmmavis commented Feb 14, 2020

image

Confirmed that we can remove the block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants