Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundation Site: Buttons & Links #317

Closed
sabrinang opened this issue Jan 16, 2019 · 11 comments
Closed

Foundation Site: Buttons & Links #317

sabrinang opened this issue Jan 16, 2019 · 11 comments
Assignees

Comments

@sabrinang
Copy link
Contributor

Description

Audit the current button and link styles on the site and examine what we want to introduce or update by referring to new blue sky ideas. Mockup new ideas in context of existing site and collect feedback. After successful review, we can prepare for implementation.

Buttons and links may include:

  • call to action buttons
  • buttons
    • main, secondary, inverse
  • button states
    • active, hover, disabled
  • button type
    • internal link, external link
  • links
    • learn more, read more etc.
@kristinashu
Copy link
Contributor

Note #278

@sabrinang
Copy link
Contributor Author

Note: audit buttons on mobile views (margin, button alignment and button width)
example: current pages & new footer mockups have a few styles on one page
image
image

@sabrinang
Copy link
Contributor Author

@natalieworth I did an audit on existing buttons on brand working slides (slides 41-47): https://docs.google.com/presentation/d/1mQJOwKj1OQkXlhHOVa2uLX0gRPQ-PffW0B3ffXztk5w/edit?usp=sharing and I put some notes that'll guide our decision/documentation convo

@natalieworth
Copy link

Noting button progress (before speaking with Sabrina today):
Screen Shot 2019-03-18 at 1 29 56 PM

Notes from meeting:

  • fix/ check margins and alignment of buttons on the foundation site
  • make all primary buttons full-width
  • secondary buttons and ghost will be align left
  • double buttons will be stacked with 8px spacing
  • change button content to sentence case
  • evaluate the ‘disable’ button style (on buyers guide site)
  • before and after icons on buttons (social before example is on buyers guide site, external link is after on buyers guide site)
  • post petition share buttons
  • remove (?) facebook buttons

@sabrinang
Copy link
Contributor Author

sabrinang commented Mar 20, 2019

@natalieworth
Testing some of the hover states and what you have so far on invision to see them in an interactive context: https://invis.io/8QR4EO1E5TG#/353450240_Button_Test

A few hover states to confirm:

  • for popped button, does the button pushes back or shadow disappers? (I mocked up it pushing back)
  • testing out primary button hover for dark theme (light blue in mockup)
  • secondary button on dark theme is the only text that isn't black or white

@sabrinang sabrinang self-assigned this Mar 20, 2019
@kristinashu
Copy link
Contributor

This ticket is currently blocking Mavis' work on:

  • Add a donation ask above the footer of the foundation site #2833
  • Footer: remove existing email section, update footer, and add new 'email' signup to footer #2834

@sabrinang @natalieworth can one of you please summarize the decisions in an implementation ticket?

@natalieworth
Copy link

natalieworth commented Mar 26, 2019

So for notes for @sabrinang comment:

  • for popped button, the button will push back (like in the mockups)
  • I have added the primary and secondary buttons in the Style Guide/ Sketch file too for reference:

Screen Shot 2019-03-26 at 3 09 37 PM

cc @mmmavis

@sabrinang
Copy link
Contributor Author

sabrinang commented Mar 27, 2019

Button Clean up and Proposed Changes

Button class names

.btn-normal to .button-primary
.btn-ghost to .button-secondary
.btn-pop to .button-pop

Button Labels

text-transform: remove uppercase (we can't enforce sentence case in code and there will be exceptions like capitalizing names etc.)
letter-spacing: 0px (remove)

Button Styles


Button Primary Updates:
color: $white
background: $blue
hover background: $dark-blue

Button Secondary Updates:
color: $black
background: none (transparent)
border: 2px solid $black
hover background: $black
hover color: $white

Button Pop Updates:
background: none (can this be transparent with the shadow?)
hover: instead of it popping out, it presses in (example)

Dark Theme Button Styles

Button Primary Dark Theme Updates:
color: $white
background: $blue
hover background: $light-blue
hover color: $black

Button Secondary Dark Theme Updates:
color: $white
background: none (transparent)
border: 2px solid $white
hover background: $white
hover color: $black

Button Pop Dark Theme Updates:
background: none (can this be transparent with the shadow?)
border: 2px solid $white
hover: instead of it popping out, it presses in (example)

Button Arrangement

Alignment: all left-aligned (exceptions support navigation or UI like .button-pop)
Spacing: margin/padding unchanged and only primary button is full-width on mobile
Order: if there are multiple buttons order by importance left to right

Multiple buttons: always have them on separate lines with margin-bottom 8px spacing
image

@sabrinang
Copy link
Contributor Author

Buttons are also documented in UI components in wagtail: https://foundation.mozilla.org/en/docs/brand/design/ui-components/

Work in progress button elements:

Disabled Button State: to be determined
In-line Icon Button: to be determined
Grouped Buttons: to be determined
Social Buttons: to be determined

@kristinashu
Copy link
Contributor

Thank you @sabrinang @natalieworth! This is sooo good!

I'll go ahead and open an implementation ticket for Mavis, I'll just copy what you wrote above. And then I'll close this and open a follow up design ticket for the remaining button work.

That sound okay?

@kristinashu
Copy link
Contributor

Tickets:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants