Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for WoT replays v 1.10 #11

Open
sbryk opened this issue Sep 21, 2020 · 5 comments
Open

Support for WoT replays v 1.10 #11

sbryk opened this issue Sep 21, 2020 · 5 comments

Comments

@sbryk
Copy link

sbryk commented Sep 21, 2020

Hello,

do you plan to add support for WoT v 1.10? I'm trying to make it by myself, currently at figuring out how do you import game ressources. It seems to be a key for support different client versions.

@Monstrofil
Copy link
Owner

Hi, not really, but If you send me "scripts" folder (like this one https://github.com/Monstrofil/replays_unpack/tree/master/replay_unpack/clients/wot/versions/1_8_0/scripts) I will add it and make some instructions on how to add futher versions.

@sbryk
Copy link
Author

sbryk commented Sep 23, 2020

Great! Here is the scripts folder for the current WoT client https://github.com/StranikS-Scan/WorldOfTanks-Decompiled/tree/1.10/source/res/scripts

@Monstrofil
Copy link
Owner

Monstrofil commented Sep 23, 2020

Just added wot 1.10.0 support:
bc8e727

All steps needed to add new version:

  • copy existing version in replay_unpack\clients\wot\versions and name it like 1_10_0
  • replace entity_defs and entities.xml with files from WorldOfTanks-Decompiled repository
  • add test replay to autotests

Same thing can be done in examples/wot_parser, it just uses another (custom) definitions folder.

@Monstrofil
Copy link
Owner

Monstrofil commented Sep 23, 2020

Oh, it seems like decompiled files are little buggy and contain duplicates:
https://github.com/StranikS-Scan/WorldOfTanks-Decompiled/blob/1.10/source/res/scripts/entity_defs/Account.def
https://github.com/StranikS-Scan/WorldOfTanks-Decompiled/blob/1.10/source/res/scripts/entity_defs/account.def

Thus now parser works on Windows but not on Linux, I'll fix it later.

Reported initial issue in StranikS-Scan/WorldOfTanks-Decompiled#6

@StranikS-Scan
Copy link

WG created this problem when it started renaming its files. Duplicates are created by github automatically on the server. To fix the problems I need to create a new repo. However, when WG renames another part of the files again, the problem will appear again .... Use the archive from the zip\ folder, it always contains files with the correct names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants