[PORT] Adds More Quirks! #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a few new quirks so allow for some more individuality from players! ~~They're set to 0 right now for TM purposes.~~ No TM, thus spoke Melbert. To-do: - [x] Bilingual - Random extra language - [x] ~~Mutated - Random mutation~~ - [x] Big Hands (fetish content???) - Big hands trait (can't use guns) - [x] Soft-Spoken - Whisper permanently - [x] Clumsy (not a packet dropper) - Clumsy trait (clown shit) - [x] ~~Paroled Convict - Spawn with a tracking implant + prisoner armband.~~ - [x] ~~Fashionista (headmins made me do it) - Lets you pick a scarf roundstart.~~ - [x] The more the merrier. Small changes at the cost of a negative quirk or two are a fun way to develop the story. It's fun! These aren't game breaking and might lead way to some interesting interactions! :cl: Chadley add: Adds some new quirks!! add: Adds the bilingual quirk, which gives a new random language. add: Adds the big hand quirk which stops the usage of most guns. add: Adds the soft spoken quirk which forces you to whisper. add: Adds the clumsy quirk enabling the clumsy trait. /:cl: --------- Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
## About The Pull Request `pick` from an empty list, because curators already know all the languages the quirk can give you ## Why It's Good For The Game Runtime fix ## Changelog :cl: Melbert fix: Fix a runtime involving Bilingual Curators qol: Bilinguals get a message on spawn reporting which language they've learned, or a message reporting they have learned no language if they're already fluent in all possible ones. /:cl:
## About The Pull Request This was one of the tradeoffs for removing other, more consistent sources of languages, and was requested by Melbert among many others. This does go against my wanted goal of decreasing the risk of eavesdropping by other players through just magically knowing a language, but it is an expensive quirk and it is in their medical records, which makes it better than language encryption keys or silicon just innately knowing them. This also limits Bilingual to only roundstart languages (+Uncommon), rather than being randomly selected from a list (that had very useless ones like monkey, podpeople, and beachbum). This is mostly just for modularity, I didn't want to make it look terrible code-wise and thought this may be the optimal way to handle it. This is also me going back on tgstation/tgstation#71773 - which I had closed myself. ## Why It's Good For The Game If we're gonna keep the Bilingual quirk, it might as well be something players can choose the language of, it's their character and they should be allowed to decide how their character is, and it is my fault that this stupid compromise of "getting a random language" was made in the first place. It never should've happened. It now actually limits it to roundstart-only languages, so there's no way you can spy on people who prepare in advance through becoming podpeople, or monkeys, etc. ## Changelog :cl: balance: Bilingual quirk now lets you choose your language between ones given to roundstart species. balance: Foreigner and Bilingual are now mutually exclusive languages. /:cl:
Fixes Skyrat-SS13/Skyrat-tg#24715 ## About The Pull Request Just makes the softspoken quirk match its description that it should be for spoken languages. You should still be able to have people view your signs from a distance. ## Why It's Good For The Game You can still 'subtly sign' using *whisper with that quirk, but you are no longer restricted to only doing that. It didn't really make sense that you were previously. ## Changelog :cl: fix: Softspoken quirk will no longer be applied to sign language /:cl:
This was referenced Jan 27, 2024
Closed
This was referenced Jan 28, 2024
This was referenced Jan 28, 2024
Closed
Closed
This was referenced Jan 29, 2024
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports the following /tg/ PRs:
Testing Proof
Why It's Good For The Game
More character customization is good for RP!
Changelog
🆑
add: Signers no longer suffer from social anxiety's speech changes when they go non-verbal. Other effects are maintained. (00-Steven)
add: Adds the bilingual quirk, which allows you to learn a new roundstart language! (Chadley)
add: Adds the big hand quirk which stops the usage of most guns. (Chadley)
add: Adds the soft spoken quirk which forces you to whisper. (Chadley)
add: Adds the clumsy quirk enabling the clumsy trait. (Chadley)
/:cl: