Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure transfer work for tables and model tables #212

Open
skejserjensen opened this issue Sep 14, 2024 · 1 comment
Open

Ensure transfer work for tables and model tables #212

skejserjensen opened this issue Sep 14, 2024 · 1 comment

Comments

@skejserjensen
Copy link
Contributor

The storage engine adds data for both tables and model tables to DataTransfer so the data for both types of table are transferred. However, the tests for DataTransfer currently only uses model table and the use of write_compressed_segments_to_model_table() in transfer_data() implies that it DataTransfer only works for model tables. Thus, the tests should be extended to include tests for tables and any issue they find should be fixed.

@skejserjensen skejserjensen changed the title Ensure transfer work for tables and models Ensure transfer work for tables and model tables Sep 14, 2024
@CGodiksen
Copy link
Collaborator

The data transfer component has been updated to no longer use write_compressed_segments_to_model_table() exclusively. Testing for both model tables and normal tables is still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants