Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow maximum deviation while supporting all f32 values for Swing #205

Open
skejserjensen opened this issue Aug 17, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@skejserjensen
Copy link
Contributor

Currently maximum_allowed_deviation() returns a value that is lower than the error bound because inaccurate floating point math seemingly can cause deviations that are higher then the error bound when converting the first and last value to slope and intersect for Swing (it looks like it can still occur in rare cases). Since this may reduce the amount of compression that can be done, and even worse, may allow values to be stored outside the error bound, the min/max values should be converted to slope/intercept in a way that allows maximum_allowed_deviation() to always return the maximum deviation. This may require min/max to be stored as f64 instead of value as value seems to be too inaccurate to recreate the original slope/intercept.

@skejserjensen skejserjensen added the bug Something isn't working label Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant