Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning when unmitigated bool or char appears in function pointers. #101

Closed
PathogenDavid opened this issue Nov 28, 2020 · 2 comments
Closed

Add warning when unmitigated bool or char appears in function pointers. #101

PathogenDavid opened this issue Nov 28, 2020 · 2 comments
Labels
Area-Verification Issues concerning verification of the model before output generation Concept-Correctness Issues concerning the correctness of the translation from an ABI perspective Concept-OutputUsability Issues concerning whether or not the output from Biohazrd is actually usable RelativelySmall Issues that are relatively small and could be good candidates for someone's first issue.

Comments

@PathogenDavid
Copy link
Member

#99 introduced a workaround for correctness bugs which arise when a bool or char is used in the context of an unmanaged function pointer.

However if the transformation is omitted for whatever reason we will end up emitting incorrect interop code with subtle and frustrating bugs. We should add a verification to suggest running this transformation if any of these problematic types exist.
@PathogenDavid PathogenDavid added Concept-Correctness Issues concerning the correctness of the translation from an ABI perspective Area-Verification Issues concerning verification of the model before output generation Concept-OutputUsability Issues concerning whether or not the output from Biohazrd is actually usable labels Nov 28, 2020
@PathogenDavid PathogenDavid mentioned this issue Nov 28, 2020
Open
4 tasks
@PathogenDavid PathogenDavid added the RelativelySmall Issues that are relatively small and could be good candidates for someone's first issue. label Jan 1, 2021
@PathogenDavid PathogenDavid changed the title Add warning when bool or char appears in function pointers. Add warning when unmitigated bool or char appears in function pointers. Jun 21, 2021
@PathogenDavid
Copy link
Member Author

Semi-related: #100

@PathogenDavid PathogenDavid mentioned this issue Mar 14, 2022
Closed
38 tasks
@PathogenDavid
Copy link
Member Author

This was made unnecessary by #236 as we convert bool/char to NativeBoolean/NativeChar just in time during emit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Verification Issues concerning verification of the model before output generation Concept-Correctness Issues concerning the correctness of the translation from an ABI perspective Concept-OutputUsability Issues concerning whether or not the output from Biohazrd is actually usable RelativelySmall Issues that are relatively small and could be good candidates for someone's first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PathogenDavid