Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a warning/update in the HTML report that Flex rules have not been added to the validator yet #1778

Closed
emmambd opened this issue Jun 4, 2024 · 4 comments · Fixed by #1861
Assignees
Labels
enhancement New feature request or improvement on an existing feature

Comments

@emmambd
Copy link
Contributor

emmambd commented Jun 4, 2024

Describe the problem

Some stakeholders have expressed confusion that they're getting invalid errors, because Flex rules have not been implemented in the validator yet. We should include a notice in the html reports that Flex rules are yet to be implemented.

Proposed solution

Display an alert in HTML validation report when any Flex feature is registered:

  • Booking Rules
  • Predefined Routes with Deviation
  • Zone-based Demand Responsive Services
  • Fixed-Stops Demand Responsive Services

e.g "Not all GTFS-Flex validation rules have been added yet. This work is still in progress. You can manually review all the validation rules for Flex data here."

Should display at the top of the page. Can use a similar style to the alerts on the Mobility Database, but in black and white: https://mobilitydatabase.org/feeds/mdb-934

Alternatives you've considered

No response

Additional context

No response

@emmambd emmambd added enhancement New feature request or improvement on an existing feature status: Needs triage Applied to all new issues labels Jun 4, 2024
@emmambd emmambd added this to the 6.0 Validator Release milestone Jun 4, 2024
@emmambd emmambd removed the status: Needs triage Applied to all new issues label Sep 23, 2024
@cka-y cka-y self-assigned this Sep 23, 2024
@cka-y
Copy link
Contributor

cka-y commented Sep 23, 2024

Needs #1844 to be merged since there were some changes in the features naming for flex features.

@emmambd emmambd added the status: Blocked Can't work on it currently because of an external factor. label Sep 23, 2024
@qcdyx
Copy link
Contributor

qcdyx commented Sep 24, 2024

Clarification: @emmambd Shall we also add the alert on the Web UI?

Tasks:

  • add the logic based on the proposed solution
  • display the alert on the HTML report and the Web UI
  • add tests

@emmambd emmambd removed the status: Blocked Can't work on it currently because of an external factor. label Oct 1, 2024
@cka-y
Copy link
Contributor

cka-y commented Oct 1, 2024

@emmambd could you please validate that the requirements are:

  • Add an indicator in the html report when flex features are detected
  • Add a generic indicator in the web UI

@emmambd
Copy link
Contributor Author

emmambd commented Oct 1, 2024

Just in the HTML report, please!

@cka-y cka-y changed the title Include a warning/update in the Web UI that Flex rules have not been added to the validator yet Include a warning/update in the HTML report that Flex rules have not been added to the validator yet Oct 1, 2024
@cka-y cka-y linked a pull request Oct 1, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request or improvement on an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants