Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output-comparator sub-module is not being included in test_pack_doc.yml workflows #1381

Closed
bdferris-v2 opened this issue Apr 7, 2023 · 0 comments · Fixed by #1382
Closed

output-comparator sub-module is not being included in test_pack_doc.yml workflows #1381

bdferris-v2 opened this issue Apr 7, 2023 · 0 comments · Fixed by #1382
Labels
bug Something isn't working (crash, a rule has a problem) status: Needs triage Applied to all new issues tests Anything related to our tests.

Comments

@bdferris-v2
Copy link
Collaborator

bdferris-v2 commented Apr 7, 2023 •
edited
Loading

Describe the bug

Best I can tell, the output-comparator sub-module is not being included in the test_pack_doc.yml workflow.

Consider this recent run of the workflow: https://github.com/MobilityData/gtfs-validator/actions/runs/4632324347/jobs/8196254085

If you expand the "Run tests on..." section, you'll notice that the output-comparator module is not listed, while other key modules are. I discovered this because I think one of the output-comparator unit tests is actually failing under a Windows environment, but it's not blocking the workflow because it's not actually running :)

I think this has something to do with how we configure our tests.
@bdferris-v2 bdferris-v2 added bug Something isn't working (crash, a rule has a problem) status: Needs triage Applied to all new issues tests Anything related to our tests. labels Apr 7, 2023
@bdferris-v2 bdferris-v2 mentioned this issue Apr 7, 2023
Merged
4 tasks
@bdferris-v2 bdferris-v2 linked a pull request Apr 7, 2023 that will close this issue
fix: Run all sub-project tests in test_pack_doc.yml workflow #1382
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working (crash, a rule has a problem) status: Needs triage Applied to all new issues tests Anything related to our tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Run all sub-project tests in test_pack_doc.yml workflow MobilityData/gtfs-validator
1 participant
@bdferris-v2