Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save/load functions to all of the models #100

Closed
blondered opened this issue Feb 21, 2024 · 2 comments · Fixed by #206
Closed

Save/load functions to all of the models #100

blondered opened this issue Feb 21, 2024 · 2 comments · Fixed by #206
Assignees
Labels
enhancement New feature or request

Comments

@blondered
Copy link
Collaborator

Feature Description

Support for saving and loading models in appropriate formats

Why this feature?

It' just super helpful in many cases

Additional context

No response

@blondered blondered added the enhancement New feature or request label Feb 21, 2024
@blondered blondered moved this to 📋 Backlog in RecTools board Feb 21, 2024
@blondered blondered changed the title Save/load functions to all of our models Save/load functions to all of the models Feb 21, 2024
@blondered blondered moved this from 📋 Backlog to 🔖 Next in RecTools board Feb 28, 2024
@blondered
Copy link
Collaborator Author

blondered commented Jul 10, 2024

We plan to:

  1. Use numpy npz format for all applicalbe models for saving sparse and dense matrixes
  2. Use https://numpy.org/doc/stable/reference/generated/numpy.savez_compressed.html or https://numpy.org/doc/stable/reference/generated/numpy.savez.html methods. @feldlime needs to research and confirm
  3. Model params are need to be acquired from get_params model method and saved in json format
  4. Models that don't have matrixes after fitting need their fitted data to be converted to np.array and then saved in npz. Example: popular model
  5. Torch models need to use torch native formats. This is not our priority for now

We need to (these are blockers):

  1. Implement get_params method for all models (Models method to generate a dict of its hyper-params (including wrapped) #108)
  2. Initialise models from dict of params (including wrapped model params). Implement a separate method for that. Interface needs to be discussed (Wrappers initialisation from full list of hyper-params  #157)

@blondered
Copy link
Collaborator Author

When saving model fitted data and models params we need to create an archive to make it one file. @feldlime creates full description for this task

@feldlime feldlime mentioned this issue Nov 10, 2024
4 tasks
@blondered blondered assigned feldlime and unassigned mikesokolovv Nov 11, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in RecTools board Nov 11, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in RecTools board Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants