Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Non ASCII characters in filenames break the build #878

Closed
gmarty opened this issue Nov 16, 2016 · 5 comments
Closed

Non ASCII characters in filenames break the build #878

gmarty opened this issue Nov 16, 2016 · 5 comments
Labels

Comments

@gmarty
Copy link

gmarty commented Nov 16, 2016

The build returns an error if you try to generate a file with non ASCII characters in the path. This minimal example:

---
title: Japanese
route: 日本語.html
---

generates the following error message:

> phenomic build

ℹ Phenomic is starting +0.25s
✔ Copying assets +0.99s
✔ Building client files +13.44s
✔ Preparing static build +3.38s
✔ Building static files +0.21s
✖ Build failed
ReferenceError:

fetch is not defined

    at exports.default (~/simple-json-fetch/lib/index.js:10:1)
    at Object.get (~/phenomic/lib/redux/modules/pages.js:83:1)
    at Object.getPage (~/phenomic/lib/components/PageContainer/index.js:29:1)
    at PageContainer.preparePage (~/phenomic/lib/components/PageContainer/component.js:152:1)
    at PageContainer.componentWillMount (~/phenomic/lib/components/PageContainer/component.js:95:1)
    at ReactCompositeComponentWrapper.performInitialMount (~/react/lib/ReactCompositeComponent.js:350:1)
    at ReactCompositeComponentWrapper.mountComponent (~/react/lib/ReactCompositeComponent.js:257:1)
    at Object.mountComponent (~/react/lib/ReactReconciler.js:47:1)
    at ReactCompositeComponentWrapper.performInitialMount (~/react/lib/ReactCompositeComponent.js:370:1)
    at ReactCompositeComponentWrapper.mountComponent (~/react/lib/ReactCompositeComponent.js:257:1)
    at Object.mountComponent (~/react/lib/ReactReconciler.js:47:1)
    at ReactCompositeComponentWrapper.performInitialMount (~/react/lib/ReactCompositeComponent.js:370:1)
    at ReactCompositeComponentWrapper.mountComponent (~/react/lib/ReactCompositeComponent.js:257:1)
    at Object.mountComponent (~/react/lib/ReactReconciler.js:47:1)
    at ReactDOMComponent.mountChildren (~/react/lib/ReactMultiChild.js:240:1)
    at ReactDOMComponent._createContentMarkup (~/react/lib/ReactDOMComponent.js:661:1)[ truncated stack ]
@MoOx MoOx added the bug label Nov 17, 2016
@MoOx
Copy link
Owner

MoOx commented Nov 17, 2016

I think I have an idea why this trigger a "fetch" issue. Will have a look tonight.

@gmarty
Copy link
Author

gmarty commented Nov 20, 2016

I can take a look if you point me in the right direction.

@MoOx
Copy link
Owner

MoOx commented Nov 21, 2016

It might be a bit tricky to fix, I am on it.

@MoOx MoOx closed this as completed in de3f0bf Nov 21, 2016
@MoOx
Copy link
Owner

MoOx commented Nov 26, 2016

@gmarty I will do more test about that.

@MoOx MoOx reopened this Nov 26, 2016
@MoOx
Copy link
Owner

MoOx commented Mar 15, 2018

Probably fixed in v1.

@MoOx MoOx closed this as completed Mar 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants