Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatOnType add unwanted space to *args in multiline list #2048

Closed
MisLink opened this issue Jun 22, 2018 · 4 comments · Fixed by #2083
Closed

formatOnType add unwanted space to *args in multiline list #2048

MisLink opened this issue Jun 22, 2018 · 4 comments · Fixed by #2083
Assignees
Labels
area-formatting bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@MisLink
Copy link

MisLink commented Jun 22, 2018

Environment data

  • VS Code version: 1.24.1
  • Extension version (available under the Extensions sidebar): 2018.6.0
  • OS and version: macos 10.13.5
  • Python version (& distribution if applicable, e.g. Anaconda): CPython 3.6.5
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
  • Relevant/affected Python packages and their versions: formater: black 18.6b4

Actual behavior

command = [
    "ffmpeg",
    *params,  # enter
    * params,  # add a space
    "-filter_complex",
    "amerge",
    "-ac",
    "2",
    "-c:a",
    "libmp3lame",
    "-q:a",
    "4",
    dest,
]

ezgif com-video-to-gif

my config:

    "python.autoComplete.showAdvancedMembers": true,
    "python.formatting.provider": "black",
    "python.jediEnabled": true,
    "python.jediMemoryLimit": -1,
    "python.linting.pylintEnabled": false,
    "python.linting.flake8Enabled": true,
    "python.autoComplete.addBrackets": true,
    "python.sortImports.args": [
        "-ns",
        "__init__.py"
    ],

Expected behavior

command = [
    "ffmpeg",
    *params,  # enter; keep it as it is
    "-filter_complex",
    "amerge",
    "-ac",
    "2",
    "-c:a",
    "libmp3lame",
    "-q:a",
    "4",
    dest,
]

Steps to reproduce:

  1. paste code and try it.

Logs

Output for Python in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Python)

None

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)

None
@d3r3kk
Copy link

d3r3kk commented Jun 22, 2018

Hi @MisLink! Please update the issue with the contents of the original template so we can help sort this out for you. With the information above I cannot reproduce the issue on the latest versions of the editor, the extension, and Python (3.6) with Black as the formatter.

What Python interpreter are you using? Is this a virtual environment?
What version of VSCode/the Python extension are you working on?
Which formatter do you have enabled? (autopep8, black, etc...)

Please add step-by-step instructions on how to reproduce as well. These details (at minimum) are required for us to discover the problem.

@d3r3kk d3r3kk added area-formatting info-needed Issue requires more information from poster bug Issue identified by VS Code Team member as probable bug labels Jun 22, 2018
@MisLink
Copy link
Author

MisLink commented Jun 22, 2018

@d3r3kk Sorry... I mistakenly believe that reproducing is easy.

@no-response no-response bot removed the info-needed Issue requires more information from poster label Jun 22, 2018
@d3r3kk
Copy link

d3r3kk commented Jun 22, 2018

Thanks for the details, I appreciate the time you took to add all of that.
I cannot reproduce on Linux 18.04 using the same setup as you have here, as soon as we get a chance we will try and reproduce on a Mac.

@MikhailArkhipov MikhailArkhipov self-assigned this Jun 25, 2018
@MikhailArkhipov
Copy link

I'll have a look.

@MikhailArkhipov MikhailArkhipov added this to the Jul 2018 milestone Jul 2, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-formatting bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants