Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure none of the npm packages use native dependencies #1416

Closed
DonJayamanne opened this issue Apr 17, 2018 · 0 comments · Fixed by #1655
Closed

Ensure none of the npm packages use native dependencies #1416

DonJayamanne opened this issue Apr 17, 2018 · 0 comments · Fixed by #1655
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
May 2018

Comments

@DonJayamanne
Copy link

DonJayamanne commented Apr 17, 2018 •
edited
Loading

The extension should not directly or indirectly rely on any native (c code) dependencies.
This will introduce incompatibilities with different versions of VS Code (as these are built during npm install).

This needs to be added on CI,
@DonJayamanne DonJayamanne added this to the May 2018 milestone Apr 17, 2018
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Apr 17, 2018
@DonJayamanne DonJayamanne mentioned this issue May 10, 2018
Merged
2 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
May 2018
Development

Successfully merging a pull request may close this issue.

Ensure none of the npm packages rely on native dependencies DonJayamanne/pythonVSCode
2 participants
@brettcannon @DonJayamanne