Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support absolute and relative timestamps #644

Merged
merged 3 commits into from
Nov 7, 2018

Conversation

JeffreyCA
Copy link
Member

@JeffreyCA JeffreyCA commented Oct 27, 2018

Resolves #631

  1. Within one month
    screen-shot-2018-10-26-at-08 51 12-pm

  2. Within one year
    screen shot 2018-10-26 at 08 52 07 pm

  3. Beyond one year
    screen shot 2018-10-26 at 08 52 47 pm

Note: The on prefix is part of the hyperlink, just like how it is on GitHub.

About localization: The date formats in 2. and 3. are constant, but 1. uses Moment's fromNow which is based on the current locale. Is this okay?

Copy link
Contributor

@RMacfarlane RMacfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@RMacfarlane RMacfarlane merged commit 30e07b8 into microsoft:master Nov 7, 2018
@rebornix rebornix added this to the October 2018 milestone Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show absolute dates if more than a month ago
3 participants