Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhandled error if you cancel saving Azure log #639

Closed
StephenWeatherford opened this issue Nov 20, 2018 · 1 comment · Fixed by #705
Closed

Unhandled error if you cancel saving Azure log #639

StephenWeatherford opened this issue Nov 20, 2018 · 1 comment · Fixed by #705
Assignees
@rosanch
Labels
P2
Milestone
0.5.0

Comments

@StephenWeatherford
Copy link
Contributor

StephenWeatherford commented Nov 20, 2018 •
edited
Loading

  1. On ACR node -> View Azure Logs
  2. Open a build and click on the copy log icon

image

3) Cancel the save dialog

!) Error 'TypeError': Cannot read property 'fsPath' of undefined

TWO PROBLEMS:

  1. The error doesn't have the "Report An Issue" button - should wrap the call in CallWithTelemtryAndErrorHandling
  2. the error itself
@StephenWeatherford StephenWeatherford added this to the 0.6.0 milestone Nov 30, 2018
@StephenWeatherford StephenWeatherford mentioned this issue Dec 5, 2018
Closed
rosanch added a commit that referenced this issue Dec 12, 2018
@rosanch
Fixes the following issues :
0b10d1a 
	Unhandled error if you cancel saving Azure log #639
	Save Azure log dialog shows "log..log" as the filename extension #640
	docker.acr.pullimage issue #648
@rosanch
Copy link
Contributor

rosanch commented Dec 12, 2018

Fixed by #705

@rosanch rosanch closed this as completed Dec 12, 2018
@rosanch rosanch mentioned this issue Dec 12, 2018
Merged
StephenWeatherford pushed a commit that referenced this issue Dec 13, 2018
@rosanch @StephenWeatherford
ACR Fixes (Logs & Docker Pull) (#705)
e1d6d42 
* Fixes the following issues :
	Unhandled error if you cancel saving Azure log #639
	Save Azure log dialog shows "log..log" as the filename extension #640
	docker.acr.pullimage issue #648

* fixes #666

* PR #705 Fixes

* Adds telemitry to the ACR logs table listeners
rosanch added a commit that referenced this issue Feb 1, 2019
@rosanch
Fixes hovering colors over the digest, and minor typos. (#710)
a45a9a6 
* Fixes the following issues :
	Unhandled error if you cancel saving Azure log #639
	Save Azure log dialog shows "log..log" as the filename extension #640
	docker.acr.pullimage issue #648

* fixes #666

* PR #705 Fixes

* Adds telemitry to the ACR logs table listeners

* Fixes #662

* Minor ACR casing fixes
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2019
@ejizba ejizba modified the milestones: 0.7.0, 0.5.0 (webpack) May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rosanch rosanch

Labels
P2
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

ACR Fixes (Logs & Docker Pull) microsoft/vscode-docker
3 participants
@StephenWeatherford @ejizba @rosanch