Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An invalid Database Account should not prevent valid Accounts from being displayed #628

Closed
ejizba opened this issue May 10, 2018 · 2 comments
Closed

An invalid Database Account should not prevent valid Accounts from being displayed #628

ejizba opened this issue May 10, 2018 · 2 comments
Assignees
@StephenWeatherford
Labels
P1
Milestone
0.8.0

Comments

@ejizba
Copy link
Contributor

ejizba commented May 10, 2018

See this bug where a single invalid Database Account was preventing any database account from being shown. The specific error in that bug was already fixed, but other errors could still occur.

We had a similar issue in App Service that was already fixed:
Issue: microsoft/vscode-azureappservice#371
PR with fix: microsoft/vscode-azureappservice#373
@PrashanthCorp PrashanthCorp mentioned this issue May 11, 2018
Merged
@PrashanthCorp PrashanthCorp added this to the 0.8.0 milestone May 16, 2018
@StephenWeatherford StephenWeatherford self-assigned this May 17, 2018
@ejizba ejizba mentioned this issue May 17, 2018
Closed
@PrashanthCorp
Copy link
Contributor

How do we want to notify the user about an invalid account?
Do we want to have mock nodes for invalid accounts or write to output?

@StephenWeatherford
Copy link
Contributor

We want to show the error message in a mock node.

@PrashanthCorp PrashanthCorp mentioned this issue May 22, 2018
Merged
@ejizba ejizba mentioned this issue May 31, 2018
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenWeatherford StephenWeatherford

Labels
P1
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
3 participants
@StephenWeatherford @ejizba @PrashanthCorp