-
Notifications
You must be signed in to change notification settings - Fork 233
Conversation
@andxu @testforstephen Can someone review this please? |
We are on holiday in China, we will look on this PR when we are back at 10.9 |
Thanks for checking in. Have a good holiday! |
Thanks for the PR. This is a real blocker... |
@@ -3,7 +3,7 @@ | |||
|
|||
import * as React from "react"; | |||
import { Col, DropdownButton, Grid, Row } from "react-bootstrap"; | |||
import * as Select from "react-select"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this change. On the other hand, we need find out the root cause of this regression.
Could you help check the installed version of react-select on your local environment? It should be on the file of \src\views\node_modules\react-select\package.json file.
I think this might relate to the version change of react-select. If this is the case, we need fix down the react-select version for time being in the src\views\package.json ==> "react-select": "1.0.0-rc.10",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the \src\views\node_modules\react-select\package.json
, I see the following.
"_resolved": "https://registry.npmjs.org/react-select/-/react-select-1.0.0-rc.10.tgz",
"_shasum": "f137346250f9255c979fbfa21860899928772350",
"_shrinkwrap": null,
"_spec": "react-select@^1.0.0-rc.4",
In the \src\views\node_modules\react-select\src\index.js
, I see this:
export default Select;
export {
Async,
AsyncCreatable,
Creatable,
Value
};
Which aligns to the 1.0.0-rc.10 version on GitHub. https://github.com/JedWatson/react-select/blob/v1.0.0-rc.10/src/index.js#L12
in contrast to the older version upon which the extension has a dependency 1.0.0-rc.4 https://github.com/JedWatson/react-select/tree/v1.0.0-rc.4/src/ which doesn't have an explicit export of Select.
I will modify the \src\views\package.json in my PR to reflect the explicit dependency on the correct version of react-select?
Also, is there a way to add gui tests so that this issue could be found by the test suite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root cause of this issue it that: though we have a package-lock.json
file, we use the Node 6 (npm 3) in Travis CI, which does not respect the package-lock.json
file.
To avoid similar issue happen again, we still need to keep the package-lock.json
file, and update https://github.com/Microsoft/vscode-arduino/blob/master/.travis.yml#L4 to use node
(latest stable Node.js release) instead of 6
Sorry I try all changes but I dont have changes,so please could any one do a little manual |
I can confirm that the new release |
Thank you so much it work now |
I am very new to React. But, by trial and error I discovered that the offending line was:
Along with the message below, which I now assume is synonymous with 'class not found':
And the fact that the class was misnamed as
BoardConfigItemView
threw me for a loop since there is already a class with that name.Closes #419