[prometheus-cpp] Update to version 0.7.0 #6822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gjasny, thanks for the port update. Is there a particular reason for enabling testing? As a general rule we do not build tests as it brings on additional dependencies and build times for a feature that users most likely will not be using. If there isn't, I can go ahead and re-disable the tests the tests for you. Let me know! |
|
Hi @grdowns, There's no particular reason to enable the tests. By enabling but not running them you gain a check for missing symbols. Feel free to disable them, again. Thanks, |
|
@dan-shaw, could you please add a |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.