WIP: Export IFW (Beta) #1734

podsvirov · 2017-08-30T03:55:33Z

Add export to binary crossplatform repository/installer
with GUI based on QtIFW:
http://doc.qt.io/qtinstallerframework/ifw-overview.html

For correct operation of these changes,
you must use the corrected QtIFW:
https://codereview.qt-project.org/#/c/203958

Add Kinect driver to OpenNI2 port. OpenNI2 port generate Kinect driver when Kinect SDK has been installed in your system.

Dynamic path convert of Kinect SDK directory in patch file.

podsvirov · 2017-08-30T15:58:13Z

Hello everyone interested!
Today I have something to show you.
This is a stand-alone stand-alone installer created based on this change request.
Installer:
vcpkg-export-ifw-standalone.exe
Screenshot (please, do not pay attention to partial localization):

Screenshot for funny (how it's look on Debian 9 with KDE):

I will be glad to receive feedback and constructive suggestions.

podsvirov · 2017-08-30T19:35:13Z

Hello @alexkaratarakis and @ras0219-msft,
what your think about add this feature?
What is the probability of accepting my changes after revision and refactoring?

drdanz

It looks like a great addition to me...
I did not review this code, I just noticed this typo from the screenshots.

drdanz · 2017-08-31T13:41:22Z

toolsrc/src/commands_export.cpp

+            line += "<Package>";
+            lines.push_back(line); line = skip;
+            line += "<DisplayName>";
+            line += "Intergation";


There is a typo here... Intergation -> Integration (same typo also a few lines later in the comment)

Good catch. Thank you!

podsvirov · 2017-08-31T20:34:18Z

QtIFW CR203958/3 has updated.
Previousle option AllowDashInName extended and renamed to AllowAllInNameAndVersion.
Updated standalone installer:
vcpkg-export-ifw-standalone.exe
And I'm glad to announce the online installer:
vcpkg-export-ifw-online.exe
New screenshot:

Anyone can test these installers.
I will be glad to receive feedback and constructive suggestions.

podsvirov · 2017-09-01T03:39:03Z

@alexkaratarakis, ping :-)
In these changes, I need to generate the files in XML format. Please tell me how to do this most effectively within the vcpkg project?

python2 version bump

ras0219-msft · 2017-09-19T16:50:40Z

Sorry for the delay! This is really cool and we would love to merge it in with some more polish!

For the time being, we want to avoid external library dependencies to avoid the horrible bootstrapping problem. If there aren't too many fields, it may be clean enough to synthesize with Strings::format[1]. Alternatively, we sometimes just use regex as a glorified replace-all [2].

Given the significant size of the XML generation code, I think it would be best to break it into a separate function or even another file.

[1] https://github.com/Microsoft/vcpkg/blob/c2a735f6bee792d2419b0616eaa84abef91536e6/toolsrc/src/commands_integrate.cpp#L19-L25
[2] https://github.com/Microsoft/vcpkg/blob/c2a735f6bee792d2419b0616eaa84abef91536e6/toolsrc/src/commands_integrate.cpp#L85-L105

podsvirov · 2017-09-19T21:06:09Z

Hello @ras0219-msft, thanks for approving my ideas. I hope that these changes will be useful for many developers.
What about the time, then we all are busy, especially if it's about open source development (as a hobby, for me now).
Recently, I continue to work on the necessary changes in the QtIFW and CR203958/9 has updated. Previousle option AllowAllInNameAndVersion now do not need at all.
@ras0219-msft, I will listen to your recommendations and try to make my code better.

Add Kinect for Windows SDK v2.x port.

podsvirov · 2017-09-20T18:42:31Z

@ras0219-msft, today I have move my code to another files. If somewere is wrong, please correct me.

ras0219-msft · 2017-09-21T08:45:24Z

toolsrc/src/commands_export.cpp

+        std::string export_id = create_export_id();
+        if (ifw)
+        {
+            export_id = "vcpkg-export"; // TODO: Remove after debugging


TODO: Remove after debugging

ras0219-msft · 2017-09-21T08:47:50Z

toolsrc/src/commands_export.cpp

+            if (ifw)
+            {
+                // Export real package and return data dir for installation
+                spec_exported_dir_path = IFW::export_real_package(raw_exported_dir_path, action, fs);


How does this handle multiple export formats at the same time (i.e. --ifw --nuget --raw)? I think either the from_destination_root() call needs to be duplicated or you could add a check that requires --ifw to not be passed with any other export types.

ras0219-msft · 2017-09-21T08:48:36Z

toolsrc/src/commands_export.cpp

            fs.create_directories(destination.parent_path(), ec);
            Checks::check_exit(VCPKG_LINE_INFO, !ec);
            fs.copy_file(source, destination, fs::copy_options::overwrite_existing, ec);
            Checks::check_exit(VCPKG_LINE_INFO, !ec);
        }

+        if (ifw)
+        {
+            // Unigue packages


ras0219-msft · 2017-09-21T08:52:31Z

toolsrc/src/commands_export.cpp

+            // Integration
+            IFW::export_integration(raw_exported_dir_path, fs);
+            // Configuration
+            IFW::export_config(raw_exported_dir_path, maybe_ifw_repository_url.value_or(""), fs);


It looks like the IFW path really isn't able to reuse much or anything from the main loop -- it might make sense to completely extract it from the loop and just have

IFW::export(export_plan, raw_exported_dir_path, fs);

Then, we'd completely skip the main loop when only running --ifw.

Note that I do think the functions should probably stay separated, but they'd be private to the IFW implementation resulting in a "cleaner" public interface.

ras0219-msft · 2017-09-21T08:52:45Z

toolsrc/src/commands_export.cpp

@@ -417,7 +460,7 @@ With a project open, go to Tools->NuGet Package Manager->Package Manager Console
            print_next_step_info("[...]");
        }

-        if (!raw)
+        if (!raw && !ifw)


I assume this was for debugging?

ras0219-msft · 2017-09-21T09:28:18Z

I pushed a commit that switches to using sprintf-style templates instead of line-by-line, which makes the code significantly more compact and (at least for me) easier to read.

podsvirov · 2017-09-21T12:25:06Z

Hello @ras0219-msft, thanks for your comments and commit. Now I will correct my mistakes.

[libspatialite] initial port

[telnetpp] Initial port for 'Telnet++'

[geos] allow geos_c static library cretation (libgeos_c.lib)

…naming convention.

podsvirov · 2017-10-04T07:01:53Z

CppCon is done... Ping :-)

Extract WiX installer using Dark. It will be standalone extract files from installer of Kinect SDK 1.x even if Kinect SDK 1.x is not installed in user system.

Fix according to changes of Kinect SDK 1.x port. Change to refer Kinect SDK 1.x that installed using vcpkg port. It will be always generate the Kinect SDK 1.x driver, even when Kinect SDK 1.x is not installed in user system.

[geos] remove build_cmake

Add Kinect SDK v2.x port

Extract Kinect SDK 1.x Installer using Dark

Change to refer Kinect SDK 1.x that installed using vcpkg port

…podsvirov-export-ifw

ras0219-msft · 2017-10-04T23:26:14Z

Thanks again for all this work, it's really incredible!

I've merged for now (with a few refactorings/housekeepings of my own); I know you have some follow-up improvements and I'd be happy to handle them through separate PRs!

podsvirov · 2017-10-04T23:46:01Z

@ras0219-msft, thank you for merging my changes. It was really unexpected for me now, but I'm very glad that it happened. Of course I have plans for further improvement and I will do this work consistently on.

podsvirov · 2017-10-05T00:08:48Z

@ras0219-msft, the problem of the first export is still relevant to me:

A suitable version of installerbase was not found (required v3.1.81). Downloadin
g portable installerbase v3.1.81...
Expected dependency downloaded path to be J:\build\vcpkg\downloads\QtInstallerFr
amework-win-x86\bin\installerbase.exe, but was ?У?З?ТA¬?ТNЧJ:\build\vcpkg\downlo
ads\QtInstallerFramework-win-x86\bin\installerbase.exe

Unexpected symbols ?У?З?ТA¬?ТNЧ...
But the tools are downloaded and unpacked normally and on subsequent attempts work as expected.

ras0219-msft · 2017-10-05T21:35:19Z

Hmm, we had some issues with byte-order marks before and were able to solve them with [1].

Could you put a breakpoint there, repro the issue, and let us know what the exact byte values are at the beginning of the response?

[1] https://github.com/Microsoft/vcpkg/blob/d8507cd159f8de6ae174cae9894c926f75fe50d7/toolsrc/src/vcpkg_System.cpp#L180-L188

podsvirov · 2017-10-05T23:25:59Z

I reproduced this and here is my result (I see 6 extra characters):

ras0219-msft · 2017-10-06T01:10:52Z

Thanks, that's really helpful! It appears you're getting two byte order marks (because your bytes weren't sufficiently ordered, I guess? 😋).

I've pushed 9b0c2cb to master which changes that function to loop until we no longer find any BOMs; I think this will solve your issue.

podsvirov · 2017-10-12T21:35:44Z

@ras0219-msft thanks, it seems that now everything works as it should.

UnaNancyOwen added 2 commits June 24, 2017 01:33

Add Kinect driver to OpenNI2 port

63153c5

Add Kinect driver to OpenNI2 port. OpenNI2 port generate Kinect driver when Kinect SDK has been installed in your system.

Dynamic path convert

1b7b814

Dynamic path convert of Kinect SDK directory in patch file.

msftclas added cla-required and removed cla-required labels Aug 30, 2017

traversaro mentioned this pull request Aug 30, 2017

Missing features robotology-playground/vcpkg-cpack#4

Open

podsvirov force-pushed the export-ifw branch from b875940 to 2d3c17c Compare August 30, 2017 15:35

drdanz reviewed Aug 31, 2017

View reviewed changes

podsvirov force-pushed the export-ifw branch from 2d3c17c to 4e08ee5 Compare August 31, 2017 20:06

podsvirov force-pushed the export-ifw branch from 4e08ee5 to 0d3789f Compare September 1, 2017 03:31

podsvirov force-pushed the export-ifw branch 3 times, most recently from 57b7956 to 1cc3222 Compare September 7, 2017 03:30

podsvirov force-pushed the export-ifw branch 2 times, most recently from 49535dd to 6f5bbdb Compare September 15, 2017 03:38

find_acquire_program fix for python2

cbc3050

python2 version bump

atkawa7 mentioned this pull request Sep 19, 2017

vcpkg ui? #1845

Closed

podsvirov force-pushed the export-ifw branch from 6f5bbdb to 3239409 Compare September 19, 2017 21:14

Add Kinect SDK v2.x port

437eb29

Add Kinect for Windows SDK v2.x port.

podsvirov force-pushed the export-ifw branch from 3239409 to c454e4b Compare September 20, 2017 18:37

ras0219-msft reviewed Sep 21, 2017

View reviewed changes

alexkaratarakis and others added 6 commits October 3, 2017 12:54

Merge pull request microsoft#1917 from alex85k/libspatialite

74e2628

[libspatialite] initial port

Merge pull request microsoft#1913 from MatthewPowley/Telnetpp

2197131

[telnetpp] Initial port for 'Telnet++'

Merge pull request microsoft#1905 from alex85k/master

3b18835

[geos] allow geos_c static library cretation (libgeos_c.lib)

[geos] Bump version for previous PR

85f0a06

[vcpkg] Add more operator== to CStringView. Uppercase Span to follow …

3838d58

…naming convention.

[gtest] Silence TR1 deprecation warning

322e925

atkawa7 and others added 12 commits October 4, 2017 05:36

[geos] remove build_cmake

bf84f92

[geos] bump version

66fdeb4

Extract WiX installer using Dark

81a72bb

Extract WiX installer using Dark. It will be standalone extract files from installer of Kinect SDK 1.x even if Kinect SDK 1.x is not installed in user system.

Merge pull request microsoft#1923 from atkawa7/patch-1

3fb9011

[geos] remove build_cmake

Merge pull request microsoft#1414 from UnaNancyOwen/add_kinectsdk2

37c155d

Add Kinect SDK v2.x port

Merge pull request microsoft#1925 from UnaNancyOwen/fix_kinectsdk1

26c06e1

Extract Kinect SDK 1.x Installer using Dark

Merge pull request microsoft#1926 from UnaNancyOwen/fix_openni2

40d531e

Change to refer Kinect SDK 1.x that installed using vcpkg port

Merge branch 'export-ifw' of https://github.com/podsvirov/vcpkg into …

a34b6ee

…podsvirov-export-ifw

[vcpkg] Reformat and fix headers.

ddbd57f

[vcpkg] Reformat and refactor to reduce function size

1b71053

[vcpkg] Refactor out implication in option parsing for export

c98db75

ras0219-msft merged commit 875a126 into microsoft:master Oct 4, 2017

podsvirov deleted the export-ifw branch October 4, 2017 23:50

traversaro mentioned this pull request Apr 20, 2018

Do not delete Qt buildtrees and packages folders! Qt no longer works. #3248

Closed

podsvirov mentioned this pull request May 5, 2022

Link vcpkg-test to log library on Android microsoft/vcpkg-tool#497

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Export IFW (Beta) #1734

WIP: Export IFW (Beta) #1734

podsvirov commented Aug 30, 2017

podsvirov commented Aug 30, 2017 •

edited

Loading

podsvirov commented Aug 30, 2017

drdanz left a comment

drdanz Aug 31, 2017

podsvirov Aug 31, 2017

podsvirov commented Aug 31, 2017

podsvirov commented Sep 1, 2017

ras0219-msft commented Sep 19, 2017 •

edited

Loading

podsvirov commented Sep 19, 2017

podsvirov commented Sep 20, 2017

ras0219-msft Sep 21, 2017

ras0219-msft Sep 21, 2017

ras0219-msft Sep 21, 2017

ras0219-msft Sep 21, 2017

ras0219-msft Sep 21, 2017

ras0219-msft commented Sep 21, 2017

podsvirov commented Sep 21, 2017

podsvirov commented Oct 4, 2017

ras0219-msft commented Oct 4, 2017

podsvirov commented Oct 4, 2017

podsvirov commented Oct 5, 2017 •

edited

Loading

ras0219-msft commented Oct 5, 2017

podsvirov commented Oct 5, 2017 •

edited

Loading

ras0219-msft commented Oct 6, 2017

podsvirov commented Oct 12, 2017

WIP: Export IFW (Beta) #1734

WIP: Export IFW (Beta) #1734

Conversation

podsvirov commented Aug 30, 2017

podsvirov commented Aug 30, 2017 • edited Loading

podsvirov commented Aug 30, 2017

drdanz left a comment

Choose a reason for hiding this comment

drdanz Aug 31, 2017

Choose a reason for hiding this comment

podsvirov Aug 31, 2017

Choose a reason for hiding this comment

podsvirov commented Aug 31, 2017

podsvirov commented Sep 1, 2017

ras0219-msft commented Sep 19, 2017 • edited Loading

podsvirov commented Sep 19, 2017

podsvirov commented Sep 20, 2017

ras0219-msft Sep 21, 2017

Choose a reason for hiding this comment

ras0219-msft Sep 21, 2017

Choose a reason for hiding this comment

ras0219-msft Sep 21, 2017

Choose a reason for hiding this comment

ras0219-msft Sep 21, 2017

Choose a reason for hiding this comment

ras0219-msft Sep 21, 2017

Choose a reason for hiding this comment

ras0219-msft commented Sep 21, 2017

podsvirov commented Sep 21, 2017

podsvirov commented Oct 4, 2017

ras0219-msft commented Oct 4, 2017

podsvirov commented Oct 4, 2017

podsvirov commented Oct 5, 2017 • edited Loading

ras0219-msft commented Oct 5, 2017

podsvirov commented Oct 5, 2017 • edited Loading

ras0219-msft commented Oct 6, 2017

podsvirov commented Oct 12, 2017

podsvirov commented Aug 30, 2017 •

edited

Loading

ras0219-msft commented Sep 19, 2017 •

edited

Loading

podsvirov commented Oct 5, 2017 •

edited

Loading

podsvirov commented Oct 5, 2017 •

edited

Loading