-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Maven dependencies and library versions + Jacoco Support for VSTS #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Resolved Conflicts: # src/test/java/com/microsoft/sqlserver/testframework/Utils.java
lilgreenbird
previously approved these changes
Oct 1, 2018
Codecov Report
@@ Coverage Diff @@
## dev #807 +/- ##
============================================
- Coverage 48.67% 48.33% -0.35%
+ Complexity 2817 2783 -34
============================================
Files 116 116
Lines 27878 27878
Branches 4651 4651
============================================
- Hits 13571 13474 -97
- Misses 12173 12185 +12
- Partials 2134 2219 +85
Continue to review full report at Codecov.
|
peterbae
reviewed
Oct 2, 2018
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecutionTest.java
Show resolved
Hide resolved
peterbae
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Adds below dependencies to resolve module access issues with new libraries.
Updates versions of Maven dependencies:
Adds "Enforce verisons" plugin to force using minimum versions of JDK and Maven for building driver to avoid any build issues.
Updates Maven plugins to their latest versions
Moves Jacoco plugins to both profiles - needed to run VSTS Code Coverage tasks.