Junit testing #432
Junit testing #432
Conversation
…emoved RandomData inside jdbc.datatypes beacuse it's redundant
|
@peterbae, |
| } | ||
|
|
||
| private static void dropTables() throws SQLException { | ||
| stmt.executeUpdate("if object_id('" + table1 + "','U') is not null" + " drop table " + table1); |
There was a problem hiding this comment.
let's use Utils.dropTable
|
|
||
| import java.math.BigDecimal; | ||
| import java.sql.Date; | ||
| import java.sql.DriverManager; |
There was a problem hiding this comment.
please delete the unused imports
| @@ -0,0 +1,2645 @@ | |||
| package com.microsoft.sqlserver.jdbc.AlwaysEncrypted; | |||
| } | ||
|
|
||
| @Test | ||
| public void testNumericPrecision8Scale2_Null() throws Exception { |
There was a problem hiding this comment.
remove _ in the test name
| .format(new Date(1450812362177L - offsetFromGMT - offsetFromGMT + offset)); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
Great work. One last comment is to add javadocs for the test methods and a general description at the beginning of the file explaining what each class file is containing and testing.
Codecov Report
@@ Coverage Diff @@
## dev #432 +/- ##
============================================
+ Coverage 45.92% 46.19% +0.27%
+ Complexity 2198 2194 -4
============================================
Files 108 108
Lines 25210 25210
Branches 4164 4164
============================================
+ Hits 11577 11646 +69
+ Misses 11711 11548 -163
- Partials 1922 2016 +94
Continue to review full report at Codecov.
|
|
Thank you @peterbae for fixing other test classes! |
Added CallableStatementTest and PrecisionScaleTest