-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for max types for TVP #259
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #259 +/- ##
===========================================
+ Coverage 33.78% 34.5% +0.71%
- Complexity 1530 1564 +34
===========================================
Files 101 102 +1
Lines 23584 23644 +60
Branches 3867 3870 +3
===========================================
+ Hits 7969 8158 +189
+ Misses 14045 13879 -166
- Partials 1570 1607 +37
Continue to review full report at Codecov.
|
fix #210 |
pstmt.setStructured(1, tvpName, tvp); | ||
|
||
pstmt.execute(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be better to add verification here (and in testLongVarchar) like you have in testXML
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added those two missing ones.
Fixes #210
Also longnvarchar, sqlxml, image.