Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for max types for TVP #259

Merged
merged 5 commits into from
Apr 26, 2017

Conversation

AfsanehR-zz
Copy link
Contributor

@AfsanehR-zz AfsanehR-zz commented Apr 21, 2017

Fixes #210
Also longnvarchar, sqlxml, image.

@codecov-io
Copy link

codecov-io commented Apr 21, 2017

Codecov Report

Merging #259 into dev will increase coverage by 0.71%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev    #259      +/-   ##
===========================================
+ Coverage     33.78%   34.5%   +0.71%     
- Complexity     1530    1564      +34     
===========================================
  Files           101     102       +1     
  Lines         23584   23644      +60     
  Branches       3867    3870       +3     
===========================================
+ Hits           7969    8158     +189     
+ Misses        14045   13879     -166     
- Partials       1570    1607      +37
Flag Coverage Δ Complexity Δ
#JDBC41 34.39% <100%> (+0.71%) 1556 <0> (+32) ⬆️
#JDBC42 34.37% <100%> (+0.72%) 1557 <0> (+35) ⬆️
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerDataTable.java 49.13% <ø> (+2.58%) 13 <0> (+1) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 39.07% <100%> (+1.53%) 0 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 43.8% <0%> (-0.49%) 61% <0%> (ø)
.../microsoft/sqlserver/jdbc/SQLServerXAResource.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/KerbAuthentication.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/JaasConfiguration.java 0% <0%> (ø) 0% <0%> (?)
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 73.79% <0%> (+0.15%) 25% <0%> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 41.45% <0%> (+0.17%) 233% <0%> (+5%) ⬆️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 46.6% <0%> (+0.37%) 197% <0%> (+3%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 58.36% <0%> (+0.4%) 129% <0%> (+1%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7228f12...be47602. Read the comment docs.

@Suraiya-Hameed
Copy link
Contributor

fix #210

@AfsanehR-zz AfsanehR-zz changed the title added support for longvarchar types for TVP added support for max types for TVP Apr 21, 2017
@ahmad-ibra ahmad-ibra self-requested a review April 26, 2017 20:11
pstmt.setStructured(1, tvpName, tvp);

pstmt.execute();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be better to add verification here (and in testLongVarchar) like you have in testXML

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added those two missing ones.

@ahmad-ibra ahmad-ibra merged commit 2208e61 into microsoft:dev Apr 26, 2017
@v-nisidh v-nisidh added this to the 6.1.7 milestone Apr 28, 2017
@AfsanehR-zz AfsanehR-zz deleted the TVP_LONGVARCHAR_types branch February 2, 2018 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants