Error message color does not have enough contrast with default console backgrounds

[tedchamb]

The vsts cli is built on knack and we have received several customer complaints that the color of red used does not provide enough contrast with the standard console backgrounds, and is therefore hard to read. Is it possible to adjust the default error message color to a brighter red that provides more contrast? It would also be good to provide a mechanism for the consuming application to choose the colors. This way we can implement a way customers can configure this in our application if they don't like the default.

Actual feedback from customer:
The error messages are printed in dark red. That's very hard to read.

[ba11b0y]

@derekbekoe I would like to take this up.

[tjprescott]

@invinciblycool that would be great!

[StingyJack]

The library should honor the hosting console's (the user's preferences) display colors and not choose an arbitrary color.

This is an accessibility issue and should be given appropriate priority. It should really not be considered a feature request.

[StingyJack]

I made this change to my local repo, but am not sure how to go about testing it where I want to see the change ultimately effected.

Is there a script that will make a locally usable knack that I can use in a local copy of azure-cli, that i can then build and run? Or should I just pip install the knack package into the azure-cli and edit there?

[tjprescott]

If you have cloned the repo, you should be able to go to the root of that repo and run pip install -e <path to knack setup.py file> --ignore-installed.

The other option would be to modify the code in you virtual environment's site-packages folder where you have the CLI installed.

[atbagga]

@StingyJack Here is the difference in the two colors (LIGHTRED_EX on top, RED at bottom) on windows command prompt. I also tried on powershell and the LIGHTRED_EX seems much better in contrast.

[tjprescott]

Fixed by PR #147.