This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Feature/updated autocollection #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 10, 2015 12:39
| @@ -311,19 +319,19 @@ public static void disableAutoPageViewTracking() { | |||
| * {@link com.microsoft.applicationinsights.library.ApplicationInsights#start()}. | |||
| */ | |||
| public static void enableAutoSessionManagement() { | |||
| if (!isRunning) { | |||
| InternalLogging.warn(TAG, "Could not set session management, because " + | |||
| if (!Util.isLifecycleTrackingAvailable()) { | |||
There was a problem hiding this comment.
We are using the same message multiple times in this class. Maybe it would be a good idea to put them elsewhere and reuse it.
added 2 commits
June 12, 2015 10:52
…tocollection # Conflicts: # applicationinsights-android/src/main/java/com/microsoft/applicationinsights/library/ApplicationInsights.java
|
@chrwend also changed the way we set the background-time. We now do it using the ComponentCallbacks2-onTrim() as it only gets called when the app is sent to background. This is pretty similar to the ApplicationDelegate-Callbacks in iOS. Unfortunately there's no "become visible"-callback for ComponentCallbacks2, so we still need the old way to detect the foregrounding. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I refactored the Lifecycletracking quite a bit.
a) Syncing when going into the background is now implemented in a separate class
b) AutoCollection is now the class for all auto-collection. Everything auto-collected can be disabled/enabled via methods on ApplicationInsights class
PS: Unit Tests are missing, will be added tomorrow, will add tomorrow.