Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Don't call LifeCycleTracking for build < 14 #48

Conversation

matthiaswenz
Copy link
Contributor

Fix for #46
Shouldn't call any methods from LifeCycleTracking on build level < 14.

@msftclas
Copy link

msftclas commented Jun 9, 2015

Hi @ranterle, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Another option would have been to make the LifeCycleTracking class public but I'd rather hide this in an implementation detail instead of exposing public API too early.
@ElektrojungeAtWork ElektrojungeAtWork added this to the 1.0-Beta.5 milestone Jun 9, 2015
@ElektrojungeAtWork ElektrojungeAtWork self-assigned this Jun 9, 2015
ElektrojungeAtWork pushed a commit that referenced this pull request Jun 9, 2015
Don't call LifeCycleTracking for build < 14
@ElektrojungeAtWork ElektrojungeAtWork merged commit b417e96 into microsoft:develop Jun 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants