From 878ae8db8e5d4e64871c446824de3fb30d4b6123 Mon Sep 17 00:00:00 2001 From: Cal-L Date: Thu, 20 Feb 2025 15:06:36 -0800 Subject: [PATCH 1/2] Update Engine controller readme for assigning codeowners --- app/core/Engine/README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/core/Engine/README.md b/app/core/Engine/README.md index f28c1f742ff..1b719cfe3bb 100644 --- a/app/core/Engine/README.md +++ b/app/core/Engine/README.md @@ -28,3 +28,6 @@ The Engine singleton is the core of the MetaMask Mobile app. It is responsible f - This allows the controller to be accessed via `Engine.context` when imported in other files - Add the controller entry to the object that `this.context` is initially set to + +- Assign files to CODEOWNERS + - Add both `app/core/Engine/controllers/` and `app/core/Engine/messengers/` to the `CODEOWNERS` file and assign to them to the appropriate team From 93ddb4a3d973a86081cd9cf59f8c76a517dfef16 Mon Sep 17 00:00:00 2001 From: Cal-L Date: Fri, 21 Feb 2025 09:47:34 -0800 Subject: [PATCH 2/2] Add necessary engine files to platform team codeowners --- .github/CODEOWNERS | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 75606e55024..b74a3c5cf56 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -9,11 +9,6 @@ app/component-library/ @MetaMask/design-system-engineers # Platform Team .github/CODEOWNERS @MetaMask/mobile-platform patches/ @MetaMask/mobile-platform -app/core/Engine/Engine.ts @MetaMask/mobile-platform -app/core/Engine/Engine.test.ts @MetaMask/mobile-platform -app/core/Engine/index.ts @MetaMask/mobile-platform -app/core/Engine/types.ts @MetaMask/mobile-platform -app/core/Engine/controllers/remote-feature-flag-controller/ @MetaMask/mobile-platform app/core/Analytics/ @MetaMask/mobile-platform app/util/metrics/ @MetaMask/mobile-platform app/components/hooks/useMetrics/ @MetaMask/mobile-platform @@ -25,6 +20,14 @@ yarn.lock @MetaMask/mobile-pla ios/Podfile.lock @MetaMask/mobile-platform app/components/Views/BrowserTab/BrowserTab.tsx @MetaMask/mobile-platform app/core/Engine/messengers/ @MetaMask/mobile-platform +app/core/Engine/utils/ @MetaMask/mobile-platform +app/core/Engine/constants/ @MetaMask/mobile-platform +app/core/Engine/Engine.test.ts @MetaMask/mobile-platform +app/core/Engine/Engine.ts @MetaMask/mobile-platform +app/core/Engine/index.ts @MetaMask/mobile-platform +app/core/Engine/README.md @MetaMask/mobile-platform +app/core/Engine/types.ts @MetaMask/mobile-platform +app/core/Engine/controllers/remote-feature-flag-controller/ @MetaMask/mobile-platform # Ramps Team app/components/UI/Ramp/ @MetaMask/ramp