fix: cp-7.41.0 Handle better errors by getting tags in pre-init

[tommasini]

Description

Handle errors in a more scalable way by adding a try catch to get tags function. Also added test coverage

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5fc8390
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/16abf2de-3675-4db6-a579-bf4ec104457c

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[Gudahtt]

Left a few suggestions.

Also, this broader try..catch will definitely solve the problem, but we could also consider splitting it up by selector or chunks of related selector. e.g. if unlocked is retrieved in a separate try..catch block, we might be able to retrieve that even before Engine initialization.

[tommasini]

@Gudahtt Kept the optional chaining, but based on your comment I think this is in a much better state! Let me know your thoughts!

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 01b88bd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c326b823-909c-4293-b884-8817a360c039

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.66%. Comparing base (b5ea162) to head (01b88bd).
Report is 13 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13598      +/-   ##
==========================================
+ Coverage   62.53%   62.66%   +0.13%     
==========================================
  Files        2005     2014       +9     
  Lines       44261    44353      +92     
  Branches     6006     6023      +17     
==========================================
+ Hits        27679    27796     +117     
+ Misses      14748    14726      -22     
+ Partials     1834     1831       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 92116e1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/645105e7-f012-4e15-b93c-afc86040f715

Note

• This comment will auto-update when build completes
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud