Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(30371): refresh activity page #30571

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Conversation

GustavoRSSilva
Copy link
Contributor

Description

Fix Issue #30371 , where refreshing the activity page would throw an error

Open in GitHub Codespaces

Related issues

Fixes: #30371 #30366

Manual testing steps

  1. Create a bridge between two tokens from different chains
  2. Go to the activity page and click on the bridge transaction details
  3. refresh the page

Screenshots/Recordings

Before

Screen.Recording.2025-02-17.at.16.48.22.mov

After

Screen.Recording.2025-02-17.at.17.09.47.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GustavoRSSilva GustavoRSSilva requested a review from a team as a code owner February 25, 2025 22:13
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@GustavoRSSilva GustavoRSSilva added the area-UI Relating to the user interface. label Feb 25, 2025
@GustavoRSSilva GustavoRSSilva changed the title Fix(30371): refresh activity page fix(30371): refresh activity page Feb 25, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [60154ed]
Page Load Metrics (1867 ± 138 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint153323791868289139
domContentLoaded151123601848284136
load152223851867288138
domInteractive25119502613
backgroundConnect108223189
firstReactRender1570362010
getState45419199
initialActions01000
loadScripts108618061375235113
setupStore75820188
uiStartup168428162125349167
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 109 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@GustavoRSSilva GustavoRSSilva added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit d249fa7 Feb 26, 2025
79 checks passed
@GustavoRSSilva GustavoRSSilva deleted the fix-30371-refresh-activity-page branch February 26, 2025 00:12
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-activity release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-bridge team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error showing bridge activity details - TypeError
4 participants