Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(30371): Error showing bridge activity details #30373

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+12 −11
Open

fix(30371): Error showing bridge activity details #30373

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8512d84
fix(30371): Error showing bridge activity details
GustavoRSSilva Feb 17, 2025
814f532
Merge branch 'main' into fix-30371-refresh-activity-page
GustavoRSSilva Feb 17, 2025
60860d1
Merge branch 'main' into fix-30371-refresh-activity-page
GustavoRSSilva Feb 17, 2025
44be1b8
Merge branch 'main' into fix-30371-refresh-activity-page
GustavoRSSilva Feb 18, 2025
b0b3a75
Merge branch 'main' into fix-30371-refresh-activity-page
GustavoRSSilva Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions ui/pages/bridge/transaction-details/transaction-details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
import { MetaMetricsContext } from '../../../contexts/metametrics';
import { formatAmount } from '../../confirmations/components/simulation-details/formatAmount';
import { getIntlLocale } from '../../../ducks/locale/locale';
import { TransactionGroup } from '../../../hooks/bridge/useBridgeTxHistoryData';
import { UseBridgeTxHistoryDataProps } from '../../../hooks/bridge/useBridgeTxHistoryData';
import TransactionActivityLog from '../../../components/app/transaction-activity-log';
import {
NETWORK_TO_SHORT_NETWORK_NAME_MAP,
Expand Down Expand Up @@ -174,10 +174,10 @@
getNetworkConfigurationsByChainId,
);

const { transactionGroup, isEarliestNonce } = location.state as {
transactionGroup: TransactionGroup;
isEarliestNonce: boolean;
};
const { transactionGroup, isEarliestNonce } = location.state

Check failure on line 177 in ui/pages/bridge/transaction-details/transaction-details.tsx

View workflow job for this annotation

GitHub Actions / Test lint / Test lint 

Initializer provides no value for this binding element and the binding element has no default value.

Check failure on line 177 in ui/pages/bridge/transaction-details/transaction-details.tsx

View workflow job for this annotation

GitHub Actions / Test lint / Test lint 

Binding element 'transactionGroup' implicitly has an 'any' type.

Check failure on line 177 in ui/pages/bridge/transaction-details/transaction-details.tsx

View workflow job for this annotation

GitHub Actions / Test lint / Test lint 

Initializer provides no value for this binding element and the binding element has no default value.

Check failure on line 177 in ui/pages/bridge/transaction-details/transaction-details.tsx

View workflow job for this annotation

GitHub Actions / Test lint / Test lint 

Binding element 'isEarliestNonce' implicitly has an 'any' type.
? (location.state as UseBridgeTxHistoryDataProps)
: {};

const srcChainTxMeta = selectedAddressTxList.find(
(tx) => tx.id === srcTxMetaId,
);
Expand Down Expand Up @@ -457,12 +457,13 @@
: undefined
}
/>

<TransactionActivityLog
transactionGroup={transactionGroup}
className="transaction-list-item-details__transaction-activity-log"
isEarliestNonce={isEarliestNonce}
/>
{transactionGroup && typeof isEarliestNonce !== 'undefined' && (
<TransactionActivityLog
transactionGroup={transactionGroup}
className="transaction-list-item-details__transaction-activity-log"
isEarliestNonce={isEarliestNonce}
/>
)}
</Box>
</Box>
</Content>
Expand Down
Loading