Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Error showing bridge activity details - TypeError #30371

Closed
GustavoRSSilva opened this issue Feb 17, 2025 · 1 comment · Fixed by #30571 · May be fixed by #30373
Closed

[Bug]: Error showing bridge activity details - TypeError #30371

GustavoRSSilva opened this issue Feb 17, 2025 · 1 comment · Fixed by #30571 · May be fixed by #30373
Labels
external-contributor regression-main Regression bug that was found on main branch, but not yet present in production release-12.14.0 Issue or pull request that will be included in release 12.14.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-bridge type-bug Something isn't working

Comments

@GustavoRSSilva
Copy link
Contributor

Describe the bug

Error when refreshing the Activity page: information is saved on the location.state that will get lost

Expected behavior

The page should show all the available information.

Screenshots/Recordings

Screen.Recording.2025-02-17.at.16.48.22.mov

Steps to reproduce

  1. Create a bridge between two different assets in different chains
  2. Go to activity page
  3. Click on a bridge transaction details
  4. refresh the page

Error messages or log output

Message: Cannot destructure property 'transactionGroup' of 'location.state' as it is undefined.

Code: TypeError

Stack:

TypeError: Cannot destructure property 'transactionGroup' of 'location.state' as it is undefined.
  at CrossChainSwapTxDetails (chrome-extension://lclmbocgbgbikcfjakfcnjhdbfhkjajb/ui-9.js:5191:5)
  at renderWithHooks (chrome-extension://lclmbocgbgbikcfjakfcnjhdbfhkjajb/common-10.js:30492:18)
  at mountIndeterminateComponent (chrome-extension://lclmbocgbgbikcfjakfcnjhdbfhkjajb/common-10.js:33026:13)
  at beginWork$1 (chrome-extension://lclmbocgbgbikcfjakfcnjhdbfhkjajb/common-10.js:34394:16)
  at HTMLUnknownElement.callCallback (chrome-extension://lclmbocgbgbikcfjakfcnjhdbfhkjajb/common-10.js:14568:14)
  at Object.invokeGuardedCallbackDev (chrome-extension://lclmbocgbgbikcfjakfcnjhdbfhkjajb/common-10.js:14617:16)
  at invokeGuardedCallback (chrome-extension://lclmbocgbgbikcfjakfcnjhdbfhkjajb/common-10.js:14672:31)

Detection stage

On main branch

Version

12.10.1

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

  • Bug only happens on expanded details
  • Going back to the activity page will fix it
@GustavoRSSilva GustavoRSSilva added the type-bug Something isn't working label Feb 17, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Feb 17, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Feb 17, 2025
@metamaskbot metamaskbot added external-contributor regression-main Regression bug that was found on main branch, but not yet present in production labels Feb 17, 2025
@DanielTech21
Copy link

Hello @GustavoRSSilva

We have released a new MetaMask extension, version 12.12.0.

Can you please confirm you are still having the issue with the latest available version?

Thank you.

@DanielTech21 DanielTech21 added team-bridge Sev2-normal Normal severity; minor loss of service or inconvenience. labels Feb 19, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2025
## **Description**

Fix Issue #30371 , where refreshing the activity page would throw an
error

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30373?quickstart=1)

## **Related issues**

Fixes: #30371 #30366

## **Manual testing steps**

1. Create a bridge between two tokens from different chains
2. Go to the activity page and click on the bridge transaction details
3. refresh the page

## **Screenshots/Recordings**

### **Before**


https://github.com/user-attachments/assets/5dd7eda1-30f1-41f5-90bc-c0a4d2d74d74

### **After**


https://github.com/user-attachments/assets/d14c402e-ac0d-4c36-8535-d02bf89645df



## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Feb 26, 2025
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Feb 26, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor regression-main Regression bug that was found on main branch, but not yet present in production release-12.14.0 Issue or pull request that will be included in release 12.14.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-bridge type-bug Something isn't working
Projects
Archived in project
Status: Fixed
3 participants