Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Error showing bridge activity details - TypeError #30366

Open
racitores opened this issue Feb 17, 2025 · 1 comment
Open

[Bug]: Error showing bridge activity details - TypeError #30366

racitores opened this issue Feb 17, 2025 · 1 comment
Labels
regression-prod-12.13.0 Regression bug that was found in production in release 12.13.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-bridge type-bug Something isn't working

Comments

@racitores
Copy link
Contributor

Describe the bug

Error when showing activity details. It happened twice with two different bridges but I wasn't able to find the reason
STX disabled (Bridge were in L2 to L2)

MetaMask.-.14.February.2025.1.mp4

Expected behavior

Bridge Tx details shouldn't fail

Screenshots/Recordings

No response

Steps to reproduce

Unsure how to reproduce the actual error but you can see something similar (not sure if it is the same issue) by:

  1. Do a bridge
  2. go to activity details
  3. refresh the page (like press F5) -> the error should happen there

Error messages or log output

Detection stage

In production (default)

Version

12.13.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

It happen with older extension versions (tested with 12.11.0)

Severity

sev2

@racitores racitores added the type-bug Something isn't working label Feb 17, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Feb 17, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Feb 17, 2025
@racitores racitores added team-bridge regression-RC-12.13.0 Regression bug that was found in release candidate (RC) for release 12.13.0 Sev2-normal Normal severity; minor loss of service or inconvenience. labels Feb 17, 2025
@metamaskbot metamaskbot added regression-prod-12.13.0 Regression bug that was found in production in release 12.13.0 and removed regression-RC-12.13.0 Regression bug that was found in release candidate (RC) for release 12.13.0 labels Feb 17, 2025
@GustavoRSSilva
Copy link
Contributor

This PR will fix this error: #30373

github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2025
## **Description**

Fix Issue #30371 , where refreshing the activity page would throw an
error

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30373?quickstart=1)

## **Related issues**

Fixes: #30371 #30366

## **Manual testing steps**

1. Create a bridge between two tokens from different chains
2. Go to the activity page and click on the bridge transaction details
3. refresh the page

## **Screenshots/Recordings**

### **Before**


https://github.com/user-attachments/assets/5dd7eda1-30f1-41f5-90bc-c0a4d2d74d74

### **After**


https://github.com/user-attachments/assets/d14c402e-ac0d-4c36-8535-d02bf89645df



## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-12.13.0 Regression bug that was found in production in release 12.13.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-bridge type-bug Something isn't working
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

3 participants