Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Gas fee is not displayed in some confirmation screens when transaction is expected to fail #17377

Closed
bschorchit opened this issue Jan 24, 2023 · 0 comments · Fixed by #17437
Closed

[Bug]: Gas fee is not displayed in some confirmation screens when transaction is expected to fail #17377

bschorchit opened this issue Jan 24, 2023 · 0 comments · Fixed by #17437
Assignees
@VSaric
Labels
release-blocker This bug is blocking the next release Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug Something isn't working

Comments

@bschorchit
Copy link

bschorchit commented Jan 24, 2023 •
edited
Loading

Describe the bug

When MM loads a confirmation screen for a transaction that is expected to fail, it's hiding the gas component and no gas information can be seen at all.

This has been seen so far on both the NFT approve and the new token allowance confirmation screens. There might be other confirmations where this might be happening as well.

Steps to reproduce

  1. Go to (erc721) https://etherscan.io/address/0x2a187453064356c898cae034eaed119e1663acb8#writeContract or (erc1155) https://etherscan.io/address/0xbc4ca0eda7647a8ab7c2061c2e118a18a936f13d#writeContract
  2. Connect your wallet
  3. Go to approve and input a random address and a random token id (I used 1, it's important that you don't actually own that NFT)
  4. Click on Write
  5. Notice that the MM popup does not show the gas component

@seaona might also have repro steps for the token allowance

Error messages or log output

No response

Version

10.24.1

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

Screenshot (MM v10.24.1):
Screenshot 2023-01-24 at 12 04 27

Screenshot (MM v10.23.1):
Screenshot 2023-01-24 at 12 18 58
@bschorchit bschorchit added type-bug Something isn't working team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. labels Jan 24, 2023
@seaona seaona mentioned this issue Jan 24, 2023
Closed
@bschorchit bschorchit changed the title [Bug]: Gas fee is not displayed in confirmation screens when transaction is expected to fail [Bug]: Gas fee is not displayed in some confirmation screens when transaction is expected to fail Jan 24, 2023
@bschorchit bschorchit added Sev2-normal Normal severity; minor loss of service or inconvenience. and removed Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. labels Jan 24, 2023
@danjm danjm mentioned this issue Jan 25, 2023
Closed
@VSaric VSaric mentioned this issue Jan 26, 2023
Merged
@hilvmason hilvmason added the release-blocker This bug is blocking the next release label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VSaric VSaric

Labels
release-blocker This bug is blocking the next release Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug Something isn't working
Projects
None yet
Milestone
No milestone
5 participants
@gauthierpetetin @danjm @bschorchit @VSaric @hilvmason